kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

First pass cleanup of test code

Browse Source
This commit is contained in:
bgbsww
2023-12-21 14:34:37 -05:00
parent 1e42235a5d
commit 4f384c41a2
3 changed files with 30 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/src/Mod/Part/App/FeaturePartCommon.cpp
View File

@@ -12,8 +12,6 @@
#include "Mod/Part/App/FeaturePartCommon.h"
#include <src/App/InitApplication.h>
// #include <BRep_TVertex.hxx>
// Should some of this go into a FeaturePartBoolean.cpp test suite?
class FeaturePartCommonTest: public ::testing::Test
@@ -196,8 +194,6 @@ TEST_F(FeaturePartCommonTest, testMustExecute)
TEST_F(FeaturePartCommonTest, testGetProviderName)
{
// Arrange
// Act
_common->execute();
const char* name = _common->getViewProviderName();

62
tests/src/Mod/Part/App/FeaturePartCut.cpp
View File

@@ -96,12 +96,12 @@ TEST_F(FeaturePartCutTest, testIntersecting)
Base::BoundBox3d bb = ts.getBoundBox();
// Assert
EXPECT_EQ(bb.MinX, 0);
EXPECT_EQ(bb.MinY, 0);
EXPECT_EQ(bb.MinZ, 0);
EXPECT_EQ(bb.MaxX, 1);
EXPECT_EQ(bb.MaxY, 1);
EXPECT_EQ(bb.MaxZ, 3);
EXPECT_FLOAT_EQ(bb.MinX, 0);
EXPECT_FLOAT_EQ(bb.MinY, 0);
EXPECT_FLOAT_EQ(bb.MinZ, 0);
EXPECT_FLOAT_EQ(bb.MaxX, 1);
EXPECT_FLOAT_EQ(bb.MaxY, 1);
EXPECT_FLOAT_EQ(bb.MaxZ, 3);
}
TEST_F(FeaturePartCutTest, testNonIntersecting)
@@ -116,12 +116,12 @@ TEST_F(FeaturePartCutTest, testNonIntersecting)
Base::BoundBox3d bb = ts.getBoundBox();
// Assert
EXPECT_EQ(bb.MinX, 0);
EXPECT_EQ(bb.MinY, 0);
EXPECT_EQ(bb.MinZ, 0);
EXPECT_EQ(bb.MaxX, 1);
EXPECT_EQ(bb.MaxY, 2);
EXPECT_EQ(bb.MaxZ, 3);
EXPECT_FLOAT_EQ(bb.MinX, 0);
EXPECT_FLOAT_EQ(bb.MinY, 0);
EXPECT_FLOAT_EQ(bb.MinZ, 0);
EXPECT_FLOAT_EQ(bb.MaxX, 1);
EXPECT_FLOAT_EQ(bb.MaxY, 2);
EXPECT_FLOAT_EQ(bb.MaxZ, 3);
}
TEST_F(FeaturePartCutTest, testTouching)
@@ -136,12 +136,12 @@ TEST_F(FeaturePartCutTest, testTouching)
Base::BoundBox3d bb = ts.getBoundBox();
// Assert
EXPECT_EQ(bb.MinX, 0);
EXPECT_EQ(bb.MinY, 0);
EXPECT_EQ(bb.MinZ, 0);
EXPECT_EQ(bb.MaxX, 1);
EXPECT_EQ(bb.MaxY, 2);
EXPECT_EQ(bb.MaxZ, 3);
EXPECT_FLOAT_EQ(bb.MinX, 0);
EXPECT_FLOAT_EQ(bb.MinY, 0);
EXPECT_FLOAT_EQ(bb.MinZ, 0);
EXPECT_FLOAT_EQ(bb.MaxX, 1);
EXPECT_FLOAT_EQ(bb.MaxY, 2);
EXPECT_FLOAT_EQ(bb.MaxZ, 3);
}
TEST_F(FeaturePartCutTest, testAlmostTouching)
@@ -156,12 +156,12 @@ TEST_F(FeaturePartCutTest, testAlmostTouching)
Base::BoundBox3d bb = ts.getBoundBox();
// Assert
EXPECT_EQ(bb.MinX, 0);
EXPECT_EQ(bb.MinY, 0);
EXPECT_EQ(bb.MinZ, 0);
EXPECT_EQ(bb.MaxX, 1);
EXPECT_EQ(bb.MaxY, 2);
EXPECT_EQ(bb.MaxZ, 3);
EXPECT_FLOAT_EQ(bb.MinX, 0);
EXPECT_FLOAT_EQ(bb.MinY, 0);
EXPECT_FLOAT_EQ(bb.MinZ, 0);
EXPECT_FLOAT_EQ(bb.MaxX, 1);
EXPECT_FLOAT_EQ(bb.MaxY, 2);
EXPECT_FLOAT_EQ(bb.MaxZ, 3);
}
TEST_F(FeaturePartCutTest, testBarelyIntersecting)
@@ -176,12 +176,12 @@ TEST_F(FeaturePartCutTest, testBarelyIntersecting)
Base::BoundBox3d bb = ts.getBoundBox();
// Assert
EXPECT_EQ(bb.MinX, 0);
EXPECT_EQ(bb.MinY, 0);
EXPECT_EQ(bb.MinZ, 0);
EXPECT_EQ(bb.MaxX, 1);
EXPECT_EQ(bb.MaxY, 1.9999);
EXPECT_EQ(bb.MaxZ, 3);
EXPECT_FLOAT_EQ(bb.MinX, 0);
EXPECT_FLOAT_EQ(bb.MinY, 0);
EXPECT_FLOAT_EQ(bb.MinZ, 0);
EXPECT_FLOAT_EQ(bb.MaxX, 1);
EXPECT_FLOAT_EQ(bb.MaxY, 1.9999);
EXPECT_FLOAT_EQ(bb.MaxZ, 3);
}
TEST_F(FeaturePartCutTest, testMustExecute)
@@ -206,8 +206,6 @@ TEST_F(FeaturePartCutTest, testMustExecute)
TEST_F(FeaturePartCutTest, testGetProviderName)
{
// Arrange
// Act
_cut->execute();
const char* name = _cut->getViewProviderName();

2
tests/src/Mod/Part/App/FeaturePartFuse.cpp
View File

@@ -206,8 +206,6 @@ TEST_F(FeaturePartFuseTest, testMustExecute)
TEST_F(FeaturePartFuseTest, testGetProviderName)
{
// Arrange
// Act
_fuse->execute();
const char* name = _fuse->getViewProviderName();