Merge pull request #19946 from j-hap/fix_double_free

TechDraw: Fix double free when resetting line formats
2025-03-11 20:29:06 +00:00
parent 6be9683ca9 922ceb8b9e
commit 5281e07029
1 changed files with 2 additions and 6 deletions
--- a/src/Mod/TechDraw/App/CosmeticExtension.cpp
+++ b/src/Mod/TechDraw/App/CosmeticExtension.cpp
@@ -594,12 +594,8 @@ void CosmeticExtension::removeCenterLine(const std::vector<std::string>& delTags

 void CosmeticExtension::clearGeomFormats()
 {
-    std::vector<GeomFormat*> noFormats;
-    std::vector<GeomFormat*> fmts = GeomFormats.getValues();
-    GeomFormats.setValues(noFormats);
-    for (auto& f : fmts) {
-        delete f;
-    }
+  // setValues takes care of deletion of old entries as well
+    GeomFormats.setValues({});
 }

 //returns unique GF id