kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[ArchWall] Fix Regression - EnsureBase prevent creation without Base

Browse Source 
Refer to discussion at -
https://github.com/FreeCAD/FreeCAD/pull/18651
https://github.com/FreeCAD/FreeCAD/issues/16409

Wall should do without Base. Base validity tested in execute() prevented the desired and documented behaviour.

EnsureBase() is remarked out in execute() and to be run in getExtrusionData().  With this fix, if there is no Base, or Base is not valid, Wall would be created as declared.
This commit is contained in:
Paul Lee
2025-01-04 19:12:11 +08:00
committed by Yorik van Havre
parent 9e42d21618
commit 5e99383934
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Mod/BIM/ArchWall.py
View File

@@ -318,8 +318,11 @@ class _Wall(ArchComponent.Component):
if self.clone(obj):
return
if not self.ensureBase(obj):
return
# Wall can do without Base, validity to be tested in getExtrusionData()
# Remarked out ensureBase() below
#if not self.ensureBase(obj):
# return
import Part
import DraftGeomUtils
@@ -832,7 +835,7 @@ class _Wall(ArchComponent.Component):
if not height:
return None
if obj.Normal == Vector(0,0,0):
if obj.Base:
if obj.Base and hasattr(obj.Base,'Shape'):
normal = DraftGeomUtils.get_shape_normal(obj.Base.Shape)
if normal is None:
normal = Vector(0,0,1)
@@ -863,7 +866,8 @@ class _Wall(ArchComponent.Component):
elif varwidth:
layers.append(varwidth)
if obj.Base:
# Check if there is obj.Base and its validity to proceed
if self.ensureBase(obj):
if hasattr(obj.Base,'Shape'):
if obj.Base.Shape:
if obj.Base.Shape.Solids:
@@ -1210,6 +1214,8 @@ class _Wall(ArchComponent.Component):
if baseface:
base,placement = self.rebase(baseface)
# Build Wall if there is no obj.Base or even obj.Base is not valid
else:
if layers:
totalwidth = sum([abs(l) for l in layers])