Path: misc. source comment typos
This commit is contained in:
@@ -331,7 +331,7 @@ static std::vector<gp_Pnt> discretize(const TopoDS_Edge &edge, double deflection
|
||||
// NOTE: OCCT QuasiUniformDeflection has a bug cause it to return only
|
||||
// partial points for some (BSpline) curve if we pass in the edge trimmed
|
||||
// first and last parameters. Passing the original curve first and last
|
||||
// paramaters works fine. The following algorithm uses the original curve
|
||||
// parameters works fine. The following algorithm uses the original curve
|
||||
// parameters, and skip those out of range. The algorithm shall work the
|
||||
// same for any other discetization algorithm, althgouth it seems only
|
||||
// QuasiUniformDeflection has this bug.
|
||||
@@ -341,7 +341,7 @@ static std::vector<gp_Pnt> discretize(const TopoDS_Edge &edge, double deflection
|
||||
Standard_Failure::Raise("Curve discretization failed");
|
||||
if(discretizer.NbPoints () > 1) {
|
||||
int nbPoints = discretizer.NbPoints ();
|
||||
//strangly OCC discretizer points are one-based, not zero-based, why?
|
||||
//strangely OCC discretizer points are one-based, not zero-based, why?
|
||||
if(reversed) {
|
||||
for (int i=nbPoints-1; i>=1; --i) {
|
||||
auto param = discretizer.Parameter(i);
|
||||
|
||||
@@ -23,7 +23,7 @@
|
||||
#ifndef PATH_AreaParams_H
|
||||
#define PATH_AreaParams_H
|
||||
|
||||
// deifne this to enable offset algo selection
|
||||
// define this to enable offset algo selection
|
||||
// #define AREA_OFFSET_ALGO
|
||||
|
||||
/** \file
|
||||
|
||||
@@ -53,7 +53,7 @@
|
||||
<item row="0" column="1">
|
||||
<widget class="QComboBox" name="boundaryShape">
|
||||
<property name="toolTip">
|
||||
<string><html><head/><body><p>Specify if the facing should be restricted by the actual shape of the selected face (or the part if no face is selected), or if the bounding box shold be faced off.</p><p>The latter can be used to face of the entire stock area to ensure uniform heights for the following operations.</p></body></html></string>
|
||||
<string><html><head/><body><p>Specify if the facing should be restricted by the actual shape of the selected face (or the part if no face is selected), or if the bounding box should be faced off.</p><p>The latter can be used to face of the entire stock area to ensure uniform heights for the following operations.</p></body></html></string>
|
||||
</property>
|
||||
<item>
|
||||
<property name="text">
|
||||
|
||||
@@ -77,7 +77,7 @@
|
||||
<item row="3" column="1">
|
||||
<widget class="Gui::InputField" name="ifRadius">
|
||||
<property name="toolTip">
|
||||
<string><html><head/><body><p>Radius of the fillet on the tag's top edge.</p><p>If the radius is bigger than than the tag shape itself supports the resulting shape will be that of a dome.</p></body></html></string>
|
||||
<string><html><head/><body><p>Radius of the fillet on the tag's top edge.</p><p>If the radius is bigger than that which the the tag shape itself supports, the resulting shape will be that of a dome.</p></body></html></string>
|
||||
</property>
|
||||
</widget>
|
||||
</item>
|
||||
|
||||
@@ -302,7 +302,7 @@ class ObjectDressup:
|
||||
by going the path backwards until the original plunge end point is reached
|
||||
4. Continue with the original path
|
||||
|
||||
This method causes unecessarily many moves with tool down
|
||||
This method causes many unnecessary moves with tool down.
|
||||
"""
|
||||
outedges = []
|
||||
rampremaining = projectionlen
|
||||
@@ -365,10 +365,10 @@ class ObjectDressup:
|
||||
1. Start from the original startpoint of the plunge
|
||||
2. Ramp down along the path that comes after the plunge until
|
||||
traveled half of the Z distance
|
||||
3. Change direction and ramp backwards to the origianal plunge end point
|
||||
3. Change direction and ramp backwards to the original plunge end point
|
||||
4. Continue with the original path
|
||||
|
||||
This method causes unecessarily many moves with tool down
|
||||
This method causes many unnecessary moves with tool down.
|
||||
"""
|
||||
outedges = []
|
||||
rampremaining = projectionlen
|
||||
|
||||
@@ -221,7 +221,7 @@ class TaskPanelPage(object):
|
||||
|
||||
def pageUpdateData(self, obj, prop):
|
||||
'''pageUpdateData(obj, prop) ... internal callback.
|
||||
Do not overwrite, implement updateData(obj) instaed.'''
|
||||
Do not overwrite, implement updateData(obj) instead.'''
|
||||
self.updateData(obj, prop)
|
||||
|
||||
def setTitle(self, title):
|
||||
|
||||
@@ -58,7 +58,7 @@ class TaskPanelOpPage(PathOpGui.TaskPanelPage):
|
||||
pass
|
||||
|
||||
def getForm(self):
|
||||
'''getForm() ... returns UI, adapted to the resutls from pocketFeatures()'''
|
||||
'''getForm() ... returns UI, adapted to the results from pocketFeatures()'''
|
||||
form = FreeCADGui.PySideUic.loadUi(":/panels/PageOpPocketFullEdit.ui")
|
||||
|
||||
if not FeatureFacing & self.pocketFeatures():
|
||||
|
||||
@@ -188,7 +188,7 @@ class TestPathGeom(PathTestBase):
|
||||
self.assertLine(PathGeom.edgeForCmd(Path.Command('G01', {'X': 1, 'Y': 3, 'Z': 5}), spt), spt, Vector(1, 3, 5))
|
||||
|
||||
def test20(self):
|
||||
"""Verfiy proper geometry for arcs in the XY-plane are created."""
|
||||
"""Verify proper geometry for arcs in the XY-plane are created."""
|
||||
p1 = Vector(0, -1, 2)
|
||||
p2 = Vector(-1, 0, 2)
|
||||
self.assertArc(
|
||||
|
||||
@@ -102,7 +102,7 @@ namespace geoff_geometry {
|
||||
rotate.e[8] = rotAxis->getx() * rotAxis->getz() * oneminusc - rotAxis->gety() * sinang;
|
||||
rotate.e[9] = rotAxis->gety() * rotAxis->getz() * oneminusc + rotAxis->getx() * sinang;
|
||||
rotate.e[10] = rotAxis->getz() * rotAxis->getz() * oneminusc + cosang;
|
||||
Multiply(rotate); // concatinate rotation with this matrix
|
||||
Multiply(rotate); // concatenate rotation with this matrix
|
||||
m_unit = false;
|
||||
m_mirrored = -1; // don't know
|
||||
}
|
||||
@@ -139,7 +139,7 @@ namespace geoff_geometry {
|
||||
rotate.e[4] = sinang;
|
||||
break;
|
||||
}
|
||||
Multiply(rotate); // concatinate rotation with this matrix
|
||||
Multiply(rotate); // concatenate rotation with this matrix
|
||||
m_unit = false;
|
||||
m_mirrored = -1; // don't know
|
||||
}
|
||||
@@ -165,7 +165,7 @@ namespace geoff_geometry {
|
||||
}
|
||||
void Matrix::Multiply(Matrix& m)
|
||||
{
|
||||
// multiply this by give matrix - concatinate
|
||||
// multiply this by give matrix - concatenate
|
||||
int i, k, l;
|
||||
Matrix ret;
|
||||
|
||||
|
||||
@@ -639,7 +639,7 @@ inline bool FNEZ(double a, double tolerance = TIGHT_TOLERANCE) {return fabs(a) >
|
||||
Point On(const CLine& s, const Point& p); // returns a point on s nearest to p
|
||||
Point On(const Circle& c, const Point& p); // returns a point on c nearest to p
|
||||
|
||||
// cline definitons
|
||||
// cline definitions
|
||||
|
||||
CLine AtAngle(double angle, const Point& p, const CLine& s = HORIZ_CLINE); // cline at angle to line thro' point
|
||||
CLine Tanto(int AT, const Circle& c, double angle, const CLine& s0 = HORIZ_CLINE);//// cline tanto circle at angle to optional cline
|
||||
|
||||
Reference in New Issue
Block a user