kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

GeometryExtensions: Add override when overriding virtual functions (EMCPP Item 12)

Browse Source
This commit is contained in:
Abdullah Tahiri
2019-03-13 17:20:05 +01:00
committed by wmayer
parent 143f697310
commit 614a031814
3 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Mod/Part/App/GeometryDefaultExtension.h
View File

@@ -36,19 +36,19 @@ namespace Part {
public:
inline GeometryDefaultExtension();
GeometryDefaultExtension(const T& val, std::string name = std::string());
virtual ~GeometryDefaultExtension() = default;
virtual ~GeometryDefaultExtension() override = default;
inline void setValue(const T& val) {value = val;};
inline const T &getValue() const {return value;};
// Persistence implementer ---------------------
virtual unsigned int getMemSize(void) const;
virtual void Save(Base::Writer &/*writer*/) const;
virtual void Restore(Base::XMLReader &/*reader*/);
virtual unsigned int getMemSize(void) const override;
virtual void Save(Base::Writer &/*writer*/) const override;
virtual void Restore(Base::XMLReader &/*reader*/) override;
virtual std::unique_ptr<Part::GeometryExtension> copy(void) const;
virtual std::unique_ptr<Part::GeometryExtension> copy(void) const override;
virtual PyObject *getPyObject(void);
virtual PyObject *getPyObject(void) override;
private:
GeometryDefaultExtension(const GeometryDefaultExtension<T>&) = default;

12
src/Mod/Sketcher/App/ExternalGeometryExtension.h
View File

@@ -46,16 +46,16 @@ public:
constexpr static std::array<const char *,NumFlags> flag2str {{ "Defining", "Frozen", "Detached","Missing", "Sync" }};
ExternalGeometryExtension() = default;
virtual ~ExternalGeometryExtension() = default;
virtual ~ExternalGeometryExtension() override = default;
// Persistence implementer ---------------------
virtual unsigned int getMemSize(void) const;
virtual void Save(Base::Writer &/*writer*/) const;
virtual void Restore(Base::XMLReader &/*reader*/);
virtual unsigned int getMemSize(void) const override;
virtual void Save(Base::Writer &/*writer*/) const override;
virtual void Restore(Base::XMLReader &/*reader*/) override;
virtual std::unique_ptr<Part::GeometryExtension> copy(void) const;
virtual std::unique_ptr<Part::GeometryExtension> copy(void) const override;
virtual PyObject *getPyObject(void);
virtual PyObject *getPyObject(void) override;
// START_CREDIT_BLOCK: Credit under LGPL for this block to Zheng, Lei (realthunder) <realthunder.dev@gmail.com>
bool testFlag(int flag) const { return Flags.test((size_t)(flag)); }

12
src/Mod/Sketcher/App/SketchGeometryExtension.h
View File

@@ -35,16 +35,16 @@ class SketcherExport SketchGeometryExtension : public Part::GeometryExtension
public:
SketchGeometryExtension();
SketchGeometryExtension(long cid);
virtual ~SketchGeometryExtension() = default;
virtual ~SketchGeometryExtension() override = default;
// Persistence implementer ---------------------
virtual unsigned int getMemSize(void) const;
virtual void Save(Base::Writer &/*writer*/) const;
virtual void Restore(Base::XMLReader &/*reader*/);
virtual unsigned int getMemSize(void) const override;
virtual void Save(Base::Writer &/*writer*/) const override;
virtual void Restore(Base::XMLReader &/*reader*/) override;
virtual std::unique_ptr<Part::GeometryExtension> copy(void) const;
virtual std::unique_ptr<Part::GeometryExtension> copy(void) const override;
virtual PyObject *getPyObject(void);
virtual PyObject *getPyObject(void) override;
long getId() const {return Id;}
void setId(long id) {Id = id;}