kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: Fix refresh on boolean property toggle

Browse Source
This commit is contained in:
Pieter Hijma
2025-11-24 20:59:20 +01:00
committed by Chris Hennes
parent 8604c26ce3
commit 63f739b2e4
1 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/Gui/propertyeditor/PropertyItemDelegate.cpp
View File

@@ -203,6 +203,8 @@ bool PropertyItemDelegate::eventFilter(QObject* o, QEvent* ev)
auto parentEditor = qobject_cast<PropertyEditor*>(this->parent());
if (parentEditor && parentEditor->activeEditor == checkBox) {
checkBox->toggle();
// Delay valueChanged to ensure proper recomputation
QTimer::singleShot(0, this, [this]() { valueChanged(); });
}
}
}
@@ -253,6 +255,19 @@ QWidget* PropertyItemDelegate::createEditor(
parentEditor->closeEditor();
}
auto createEditor = [this, childItem, parent]() {
// Can't use a terniary here because the lambdas have different types.
if (qobject_cast<PropertyBoolItem*>(childItem)) {
// Boolean properties use a checkbox that is basically artificial
// (it is not rendered). Therefore, the callback is handled in
// eventFilter()
return childItem->createEditor(parent, []() noexcept {});
}
return childItem->createEditor(parent, [this]() {
const_cast<PropertyItemDelegate*>(this)->valueChanged(); // NOLINT
});
};
FC_LOG("create editor " << index.row() << "," << index.column());
QWidget* editor = nullptr;
expressionEditor = nullptr;
@@ -270,10 +285,7 @@ QWidget* PropertyItemDelegate::createEditor(
propertyEditor = editor;
}
else {
editor = childItem->createEditor(parent, [this]() {
const_cast<PropertyItemDelegate*>(this)->valueChanged(); // NOLINT
});
propertyEditor = editor;
propertyEditor = editor = createEditor();
}
}
if (editor) {