kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: Fix clarify selection menu HiDPI positioning issues

Browse Source 
On HiDPI screens, the Clarify Selection context menu appears
far to the right of the intended position when triggered via
right-click, which was making it really problematic to select entities.

So the easiest solution is to apply `devicePixeLRatio` scaling when
converting the stored right-click postiion from device pixels to Qt
logical coordinates before calling `mapToGlobal()`.
This commit is contained in:
tetektoza
2025-09-26 22:22:51 +02:00
committed by Chris Hennes
parent b3fd31b108
commit 68b754effd
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Gui/CommandView.cpp
View File

@@ -3998,8 +3998,10 @@ void StdCmdClarifySelection::activated(int iMsg)
} else {
QPoint pos = QCursor::pos();
QPoint local = widget->mapFromGlobal(pos);
point = SbVec2s(static_cast<short>(local.x()),
static_cast<short>(widget->height() - local.y() - 1));
qreal devicePixelRatio = widget->devicePixelRatioF();
point = SbVec2s(static_cast<short>(local.x() * devicePixelRatio),
static_cast<short>((widget->height() - local.y() - 1) * devicePixelRatio));
}
// Use ray picking to get all objects under cursor
@@ -4071,7 +4073,11 @@ void StdCmdClarifySelection::activated(int iMsg)
QPoint globalPos;
if (storedPosition.has_value()) {
globalPos = widget->mapToGlobal(QPoint(point[0], widget->height() - point[1] - 1));
qreal devicePixelRatio = widget->devicePixelRatioF();
int logicalHeight = static_cast<int>(widget->height());
QPoint localPos(static_cast<int>(point[0] / devicePixelRatio),
logicalHeight - static_cast<int>(point[1] / devicePixelRatio) - 1);
globalPos = widget->mapToGlobal(localPos);
} else {
globalPos = QCursor::pos();
}