kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PD: remove parameter 'supportface' from ProfileBased::getUpToFace as it's not used any more

Browse Source
This commit is contained in:
wmayer
2022-12-05 12:46:52 +01:00
parent 633fb4488a
commit 69aba3abe1
4 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Mod/PartDesign/App/FeaturePad.cpp
View File

@@ -157,7 +157,7 @@ App::DocumentObjectExecReturn *Pad::execute()
getFaceFromLinkSub(upToFace, UpToFace);
upToFace.Move(invObjLoc);
}
getUpToFace(upToFace, base, supportface, sketchshape, method, dir);
getUpToFace(upToFace, base, sketchshape, method, dir);
addOffsetToFace(upToFace, dir, Offset.getValue());
// TODO: Write our own PrismMaker which does not depend on a solid base shape

2
src/Mod/PartDesign/App/FeaturePocket.cpp
View File

@@ -167,7 +167,7 @@ App::DocumentObjectExecReturn *Pocket::execute()
getFaceFromLinkSub(upToFace, UpToFace);
upToFace.Move(invObjLoc);
}
getUpToFace(upToFace, base, supportface, profileshape, method, dir);
getUpToFace(upToFace, base, profileshape, method, dir);
addOffsetToFace(upToFace, dir, Offset.getValue());
// BRepFeat_MakePrism(..., 2, 1) in combination with PerForm(upToFace) is buggy when the

1
src/Mod/PartDesign/App/FeatureSketchBased.cpp
View File

@@ -449,7 +449,6 @@ void ProfileBased::getFaceFromLinkSub(TopoDS_Face& upToFace, const App::Property
void ProfileBased::getUpToFace(TopoDS_Face& upToFace,
const TopoDS_Shape& support,
const TopoDS_Face& supportface,
const TopoDS_Shape& sketchshape,
const std::string& method,
const gp_Dir& dir)

1
src/Mod/PartDesign/App/FeatureSketchBased.h
View File

@@ -134,7 +134,6 @@ protected:
/// Find a valid face to extrude up to
static void getUpToFace(TopoDS_Face& upToFace,
const TopoDS_Shape& support,
const TopoDS_Face& supportface,
const TopoDS_Shape& sketchshape,
const std::string& method,
const gp_Dir& dir);