kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: Request 24-bit color depth if available

Browse Source 
In some configurations, Qt apparently defaults to giving the "first
acceptable" buffer format. This often ends up being RGB565, which
gives us little color resolution.

Request 8-bit RGB samples to fix this.

This tends to happen easiest with
`QT_WAYLAND_DISABLE_WINDOWDECORATION=1` and `QT_QPA_PLATFORM=wayland`.
This commit is contained in:
Sami Liedes
2025-09-11 01:41:01 +02:00
committed by Chris Hennes
parent 8bee7d3455
commit 69fb78e2c9
1 changed files with 24 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/Gui/Application.cpp
View File

@@ -2384,11 +2384,30 @@ void Application::runApplication()
{
StartupProcess::setupApplication();
QSurfaceFormat fmt;
fmt.setRenderableType(QSurfaceFormat::OpenGL);
fmt.setProfile(QSurfaceFormat::CompatibilityProfile);
fmt.setOption(QSurfaceFormat::DeprecatedFunctions, true);
QSurfaceFormat::setDefaultFormat(fmt);
{
QSurfaceFormat defaultFormat;
defaultFormat.setRenderableType(QSurfaceFormat::OpenGL);
defaultFormat.setProfile(QSurfaceFormat::CompatibilityProfile);
defaultFormat.setOption(QSurfaceFormat::DeprecatedFunctions, true);
#if defined(FC_OS_LINUX) || defined(FC_OS_BSD)
// QGuiApplication::platformName() doesn't yet work at this point, so we use the env var
if (getenv("WAYLAND_DISPLAY")) {
// In some settings (at least EGL on Wayland) we get RGB565 by default.
// Request something better.
defaultFormat.setRedBufferSize(8);
defaultFormat.setGreenBufferSize(8);
defaultFormat.setBlueBufferSize(8);
// Qt's behavior with format requests seems opaque, underdocumented and,
// unfortunately, inconsistent between platforms. Requesting an alpha
// channel tends to steer it away from weird legacy choices like RGB565.
defaultFormat.setAlphaBufferSize(8);
// And a depth/stencil buffer is generally useful if we can have it.
defaultFormat.setDepthBufferSize(24);
defaultFormat.setStencilBufferSize(8);
}
#endif
QSurfaceFormat::setDefaultFormat(defaultFormat);
}
// A new QApplication
Base::Console().log("Init: Creating Gui::Application and QApplication\n");