kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

fixes 0003571: Offset3D of volumes intersection is not solid

Browse Source
This commit is contained in:
wmayer
2018-09-30 22:40:32 +02:00
parent 8bb51de89d
commit 6bcc7e6315
1 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/Mod/Part/App/TopoShape.cpp
View File

@@ -2317,14 +2317,33 @@ TopoDS_Shape TopoShape::makeOffsetShape(double offset, double tol, bool intersec
bool selfInter, short offsetMode, short join,
bool fill) const
{
// If the input shape is a compound with a single solid then the offset
// algorithm creates only a shell instead of a solid which causes errors
// when using it e.g. for boolean operations. (#0003571)
// But when extracting the solid and passing it to the algorithm the output
// shape is a solid.
TopoDS_Shape inputShape = this->_Shape;
TopExp_Explorer xp;
xp.Init(inputShape, TopAbs_VERTEX, TopAbs_SOLID);
if (!xp.More()) {
xp.Init(inputShape, TopAbs_SOLID);
if (xp.More()) {
// If exactly one solid then get it
TopoDS_Shape inputSolid = xp.Current();
xp.Next();
if (xp.More() == Standard_False)
inputShape = inputSolid;
}
}
#if OCC_VERSION_HEX < 0x070200
BRepOffsetAPI_MakeOffsetShape mkOffset(this->_Shape, offset, tol, BRepOffset_Mode(offsetMode),
BRepOffsetAPI_MakeOffsetShape mkOffset(inputShape, offset, tol, BRepOffset_Mode(offsetMode),
intersection ? Standard_True : Standard_False,
selfInter ? Standard_True : Standard_False,
GeomAbs_JoinType(join));
#else
BRepOffsetAPI_MakeOffsetShape mkOffset;
mkOffset.PerformByJoin(this->_Shape, offset, tol, BRepOffset_Mode(offsetMode),
mkOffset.PerformByJoin(inputShape, offset, tol, BRepOffset_Mode(offsetMode),
intersection ? Standard_True : Standard_False,
selfInter ? Standard_True : Standard_False,
GeomAbs_JoinType(join));