kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[PartDesign] Fix 'Reversed' no more available in Pad 'toFirst/toLast'

Browse Source 
While useless 'Midplane' was still visible
 Bug introduced in commit #695abed1, not fixed by commmit #7d9fd5e4
 Also fixing some typos
This commit is contained in:
0penBrain
2021-07-12 18:45:50 +02:00
committed by Bernd Hahnebach
parent 8cee8adf5f
commit 7459bbb14d
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Mod/PartDesign/Gui/TaskPadParameters.cpp
View File

@@ -203,7 +203,8 @@ void TaskPadParameters::updateUI(int index)
bool isLengthEditVisible = false;
bool isLengthEdit2Visible = false;
bool isOffsetEditVisible = false;
bool isMidplateEnabled = false;
bool isMidplaneEnabled = false;
bool isMidplaneVisible = false;
bool isReversedEnabled = false;
bool isReversedVisible = false;
bool isFaceEditEnabled = false;
@@ -216,7 +217,8 @@ void TaskPadParameters::updateUI(int index)
// Calling setFocus() directly doesn't work because the spin box is not
// yet visible.
QMetaObject::invokeMethod(ui->lengthEdit, "setFocus", Qt::QueuedConnection);
isMidplateEnabled = !ui->checkBoxReversed->isChecked();
isMidplaneEnabled = !ui->checkBoxReversed->isChecked();
isMidplaneVisible = true;
// Reverse only makes sense if Midplane is not true
isReversedEnabled = !ui->checkBoxMidplane->isChecked();
isReversedVisible = true;
@@ -224,6 +226,8 @@ void TaskPadParameters::updateUI(int index)
// up to first/last
else if (index == 1 || index == 2) {
isOffsetEditVisible = true;
isReversedEnabled = true;
isReversedVisible = true;
}
// up to face
else if (index == 3) {
@@ -238,7 +242,8 @@ void TaskPadParameters::updateUI(int index)
else {
isLengthEditVisible = true;
isLengthEdit2Visible = true;
isMidplateEnabled = !ui->checkBoxReversed->isChecked();
isMidplaneEnabled = !ui->checkBoxReversed->isChecked();
isMidplaneVisible = true;
isReversedEnabled = !ui->checkBoxMidplane->isChecked();
isReversedVisible = true;
}
@@ -252,7 +257,8 @@ void TaskPadParameters::updateUI(int index)
ui->offsetEdit->setEnabled( isOffsetEditVisible );
ui->labelOffset->setVisible( isOffsetEditVisible );
ui->checkBoxMidplane->setEnabled( isMidplateEnabled );
ui->checkBoxMidplane->setEnabled( isMidplaneEnabled );
ui->checkBoxMidplane->setVisible( isMidplaneVisible );
ui->checkBoxReversed->setEnabled( isReversedEnabled );
ui->checkBoxReversed->setVisible( isReversedVisible );