kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Part: Geometry extensions set interface

Browse Source 
=======================================

unique_ptr is a move only type. Therefore it may only take an rvalue.

It does not make sense a pass by value for move only types (Item 41).
This commit is contained in:
Abdullah Tahiri
2019-02-09 20:00:09 +01:00
committed by wmayer
parent e4aead2365
commit 7488faa99f
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Mod/Part/App/Geometry.cpp
View File

@@ -288,7 +288,7 @@ const std::weak_ptr<GeometryExtension> Geometry::getExtension(Base::Type type) c
throw Base::ValueError("No geometry extension of the requested type.");
}
void Geometry::setExtension(std::unique_ptr<GeometryExtension> geo)
void Geometry::setExtension(std::unique_ptr<GeometryExtension> && geo)
{
bool hasext=false;

2
src/Mod/Part/App/Geometry.h
View File

@@ -101,7 +101,7 @@ public:
bool hasExtension(Base::Type type) const;
const std::weak_ptr<GeometryExtension> getExtension(Base::Type type) const;
void setExtension(std::unique_ptr<GeometryExtension> geo);
void setExtension(std::unique_ptr<GeometryExtension> &&geo);
protected:
/// create a new tag for the geometry object