kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Fix several clazy issues:

Browse Source 
* Don't call ... on temporary [-Wclazy-detaching-temporary]
This commit is contained in:
wmayer
2022-07-25 00:18:42 +02:00
parent 923ebef729
commit 76c993baae
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Gui/CommandView.cpp
View File

@@ -1814,7 +1814,7 @@ void StdViewScreenShot::activated(int iMsg)
if (fd.exec() == QDialog::Accepted) {
selFilter = fd.selectedNameFilter();
QString fn = fd.selectedFiles().front();
QString fn = fd.selectedFiles().constFirst();
// We must convert '\' path separators to '/' before otherwise
// Python would interpret them as escape sequences.
fn.replace(QLatin1Char('\\'), QLatin1Char('/'));

4
src/Gui/Quarter/DragDropHandler.cpp
View File

@@ -119,7 +119,7 @@ DragDropHandlerP::dragEnterEvent(QDragEnterEvent * event)
return;
if (mimedata->hasUrls()) {
QFileInfo fileinfo(mimedata->urls().takeFirst().path());
QFileInfo fileinfo(mimedata->urls().constFirst().path());
QString suffix = fileinfo.suffix().toLower();
if (!this->suffixes.contains(suffix)) {
return;
@@ -139,7 +139,7 @@ DragDropHandlerP::dropEvent(QDropEvent * event)
QByteArray bytes;
if (mimedata->hasUrls()) {
QUrl url = mimedata->urls().takeFirst();
QUrl url = mimedata->urls().constFirst();
if (url.scheme().isEmpty() || url.scheme().toLower() == QString("file") ) {
// attempt to open file
if (!in.openFile(url.toLocalFile().toLatin1().constData()))