kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

use const reference in schemaTranslate to avoid tmp. copy

Browse Source
This commit is contained in:
wmayer
2016-08-05 10:33:41 +02:00
parent 1783528282
commit 787cfc660d
9 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Base/UnitsSchema.h
View File

@@ -60,7 +60,7 @@ public:
virtual void resetSchemaUnits(void){}
/// This method translates the quantity in a string as the user may expect it.
virtual QString schemaTranslate(Base::Quantity quant,double &factor,QString &unitString)=0;
virtual QString schemaTranslate(const Base::Quantity& quant, double &factor, QString &unitString)=0;
};

2
src/Base/UnitsSchemaCentimeters.cpp
View File

@@ -36,7 +36,7 @@
using namespace Base;
QString UnitsSchemaCentimeters::schemaTranslate(Base::Quantity quant,double &factor,QString &unitString)
QString UnitsSchemaCentimeters::schemaTranslate(const Base::Quantity& quant, double &factor, QString &unitString)
{
Unit unit = quant.getUnit();
if (unit == Unit::Length) {

3
src/Base/UnitsSchemaCentimeters.h
View File

@@ -37,8 +37,7 @@ namespace Base {
class UnitsSchemaCentimeters: public UnitsSchema
{
public:
virtual QString schemaTranslate(Base::Quantity quant,double &factor,QString &unitString);
virtual QString schemaTranslate(const Base::Quantity& quant, double &factor, QString &unitString);
};
} // namespace Base

6
src/Base/UnitsSchemaImperial1.cpp
View File

@@ -58,7 +58,7 @@ using namespace Base;
// Quantity::Mile = Quantity (1609344.0 ,Unit(1));
//}
QString UnitsSchemaImperial1::schemaTranslate(Base::Quantity quant,double &factor,QString &unitString)
QString UnitsSchemaImperial1::schemaTranslate(const Quantity &quant, double &factor, QString &unitString)
{
double UnitValue = std::abs(quant.getValue());
Unit unit = quant.getUnit();
@@ -140,7 +140,7 @@ QString UnitsSchemaImperial1::schemaTranslate(Base::Quantity quant,double &facto
return QString::fromUtf8("%1 %2").arg(Ln).arg(unitString);
}
QString UnitsSchemaImperialDecimal::schemaTranslate(Base::Quantity quant,double &factor,QString &unitString)
QString UnitsSchemaImperialDecimal::schemaTranslate(const Base::Quantity& quant, double &factor, QString &unitString)
{
double UnitValue = std::abs(quant.getValue());
Unit unit = quant.getUnit();
@@ -205,7 +205,7 @@ QString UnitsSchemaImperialDecimal::schemaTranslate(Base::Quantity quant,double
return QString::fromUtf8("%1 %2").arg(Ln).arg(unitString);
}
QString UnitsSchemaImperialBuilding::schemaTranslate(Base::Quantity quant,double &factor,QString &unitString)
QString UnitsSchemaImperialBuilding::schemaTranslate(const Quantity &quant, double &factor, QString &unitString)
{
// this schema expresses distances in feet + inches + fractions
// ex: 3'- 4 1/4"

6
src/Base/UnitsSchemaImperial1.h
View File

@@ -41,7 +41,7 @@ class UnitsSchemaImperial1: public UnitsSchema
public:
//virtual void setSchemaUnits(void);
//virtual void resetSchemaUnits(void);
virtual QString schemaTranslate(Base::Quantity quant,double &factor,QString &unitString);
virtual QString schemaTranslate(const Base::Quantity& quant, double &factor, QString &unitString);
};
/** The schema class for the imperial unit system
@@ -53,7 +53,7 @@ class UnitsSchemaImperialDecimal: public UnitsSchema
public:
//virtual void setSchemaUnits(void);
//virtual void resetSchemaUnits(void);
virtual QString schemaTranslate(Base::Quantity quant,double &factor,QString &unitString);
virtual QString schemaTranslate(const Base::Quantity& quant, double &factor, QString &unitString);
};
/** The schema class for the imperial unit system
@@ -65,7 +65,7 @@ class UnitsSchemaImperialBuilding: public UnitsSchema
public:
//virtual void setSchemaUnits(void);
//virtual void resetSchemaUnits(void);
virtual QString schemaTranslate(Base::Quantity quant,double &factor,QString &unitString);
virtual QString schemaTranslate(const Base::Quantity& quant, double &factor, QString &unitString);
};

2
src/Base/UnitsSchemaInternal.cpp
View File

@@ -37,7 +37,7 @@
using namespace Base;
QString UnitsSchemaInternal::schemaTranslate(Base::Quantity quant,double &factor,QString &unitString)
QString UnitsSchemaInternal::schemaTranslate(const Quantity &quant, double &factor, QString &unitString)
{
double UnitValue = std::abs(quant.getValue());
Unit unit = quant.getUnit();

2
src/Base/UnitsSchemaInternal.h
View File

@@ -40,7 +40,7 @@ namespace Base {
class UnitsSchemaInternal: public UnitsSchema
{
public:
virtual QString schemaTranslate(Base::Quantity quant,double &factor,QString &unitString);
virtual QString schemaTranslate(const Base::Quantity& quant, double &factor, QString &unitString);
};

2
src/Base/UnitsSchemaMKS.cpp
View File

@@ -36,7 +36,7 @@
using namespace Base;
QString UnitsSchemaMKS::schemaTranslate(Base::Quantity quant,double &factor,QString &unitString)
QString UnitsSchemaMKS::schemaTranslate(const Quantity &quant, double &factor, QString &unitString)
{
double UnitValue = std::abs(quant.getValue());
Unit unit = quant.getUnit();

2
src/Base/UnitsSchemaMKS.h
View File

@@ -38,7 +38,7 @@ namespace Base {
class UnitsSchemaMKS: public UnitsSchema
{
public:
virtual QString schemaTranslate(Base::Quantity quant,double &factor,QString &unitString);
virtual QString schemaTranslate(const Base::Quantity& quant, double &factor, QString &unitString);
};