kindred/create
1
1
Fork 0
Code Issues 34 Pull Requests Actions 5 Packages Projects 9 Releases 2 Wiki Activity

PartDesign: Transformed. Fix regression for Mirrored, and multiple features

Browse Source
This commit is contained in:
David Osterberg
2021-02-28 10:10:29 +01:00
committed by wmayer
parent fecf9c2e84
commit 8453d41515
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Mod/PartDesign/App/FeatureTransformed.cpp
View File

@@ -296,7 +296,8 @@ App::DocumentObjectExecReturn *Transformed::execute(void)
bool overlapping = false;
std::vector<gp_Trsf>::const_iterator t = transformations.begin();
++t; // Skip first transformation, which is always the identity transformation
//++t; // Skip first transformation, which is always the identity transformation
bool first = true;
for (; t != transformations.end(); ++t) {
// Make an explicit copy of the shape because the "true" parameter to BRepBuilderAPI_Transform
// seems to be pretty broken
@@ -304,13 +305,19 @@ App::DocumentObjectExecReturn *Transformed::execute(void)
shape = copy.Shape();
shape.Move(*t);
BRepBuilderAPI_Transform mkTrf(shape, *t, false); // No need to copy, now
if (!mkTrf.IsDone())
return new App::DocumentObjectExecReturn("Transformation failed", (*o));
shape = mkTrf.Shape();
shapes.emplace_back(shape);
builder.Add(compShape, shape);
if (overlapDetectionMode)
if (overlapDetectionMode && !first)
overlapping = overlapping || (countSolids(TopoShape(origShape).fuse(shape))==1);
if (first)
first = false;
}
TopoDS_Shape toolShape;