kindred/create
1
1
Fork 0
Code Issues 51 Pull Requests 1 Actions 1 Packages Projects 9 Releases 2 Wiki Activity

Merge pull request #16260 from Ondsel-Development/test_fix_failing_point

Browse Source 
Test: remove unecessary toggle that is failing the test
This commit is contained in:
Chris Hennes
2024-09-03 13:22:42 -05:00
committed by GitHub
parent e3f9e192f6 d01d71198d
commit 853e3ee672
3 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/Mod/Part/parttests/regression_tests.py
View File

@@ -75,7 +75,6 @@ class RegressionTests(unittest.TestCase):
PointSketch.MapMode = "Deactivated"
PointSketch.addGeometry(Part.Point(Base.Vector(0.000000, 0.000000, 0)))
PointSketch.toggleConstruction(0)
PointSketch.addConstraint(Sketcher.Constraint("Coincident", 0, 1, -1, 1))

12
src/Mod/Sketcher/Gui/CommandConstraints.cpp
View File

@@ -406,7 +406,7 @@ void SketcherGui::makeTangentToEllipseviaNewPoint(Sketcher::SketchObject* Obj,
try {
// Add a point
Gui::cmdAppObjectArgs(Obj, "addGeometry(Part.Point(App.Vector(%f,%f,0)))", PoE.x, PoE.y);
Gui::cmdAppObjectArgs(Obj, "addGeometry(Part.Point(App.Vector(%f,%f,0)), True)", PoE.x, PoE.y);
int GeoIdPoint = Obj->getHighestCurveIndex();
// Point on first object
@@ -486,7 +486,7 @@ void SketcherGui::makeTangentToArcOfEllipseviaNewPoint(Sketcher::SketchObject* O
try {
// Add a point
Gui::cmdAppObjectArgs(Obj, "addGeometry(Part.Point(App.Vector(%f,%f,0)))", PoE.x, PoE.y);
Gui::cmdAppObjectArgs(Obj, "addGeometry(Part.Point(App.Vector(%f,%f,0)), True)", PoE.x, PoE.y);
int GeoIdPoint = Obj->getHighestCurveIndex();
// Point on first object
@@ -583,7 +583,7 @@ void SketcherGui::makeTangentToArcOfHyperbolaviaNewPoint(Sketcher::SketchObject*
try {
// Add a point
Gui::cmdAppObjectArgs(Obj, "addGeometry(Part.Point(App.Vector(%f,%f,0)))", PoH.x, PoH.y);
Gui::cmdAppObjectArgs(Obj, "addGeometry(Part.Point(App.Vector(%f,%f,0)), True)", PoH.x, PoH.y);
int GeoIdPoint = Obj->getHighestCurveIndex();
// Point on first object
@@ -673,7 +673,7 @@ void SketcherGui::makeTangentToArcOfParabolaviaNewPoint(Sketcher::SketchObject*
try {
// Add a point
Gui::cmdAppObjectArgs(Obj, "addGeometry(Part.Point(App.Vector(%f,%f,0)))", PoP.x, PoP.y);
Gui::cmdAppObjectArgs(Obj, "addGeometry(Part.Point(App.Vector(%f,%f,0)), True)", PoP.x, PoP.y);
int GeoIdPoint = Obj->getHighestCurveIndex();
// Point on first object
@@ -6150,7 +6150,7 @@ void CmdSketcherConstrainPerpendicular::activated(int iMsg)
try {
// Add a point
Gui::cmdAppObjectArgs(Obj,
"addGeometry(Part.Point(App.Vector(%f,%f,0)))",
"addGeometry(Part.Point(App.Vector(%f,%f,0)), True)",
PoO.x,
PoO.y);
int GeoIdPoint = Obj->getHighestCurveIndex();
@@ -6351,7 +6351,7 @@ void CmdSketcherConstrainPerpendicular::applyConstraint(std::vector<SelIdPair>&
try {
// Add a point
Gui::cmdAppObjectArgs(Obj,
"addGeometry(Part.Point(App.Vector(%f,%f,0)))",
"addGeometry(Part.Point(App.Vector(%f,%f,0)), True)",
PoO.x,
PoO.y);
int GeoIdPoint = Obj->getHighestCurveIndex();

11
src/Mod/Sketcher/Gui/DrawSketchHandlerPoint.h
View File

@@ -81,15 +81,10 @@ private:
try {
Gui::Command::openCommand(QT_TRANSLATE_NOOP("Command", "Add sketch point"));
Gui::cmdAppObjectArgs(sketchgui->getObject(),
"addGeometry(Part.Point(App.Vector(%f,%f,0)))",
"addGeometry(Part.Point(App.Vector(%f,%f,0)), %s)",
editPoint.x,
editPoint.y);
if (isConstructionMode()) {
Gui::cmdAppObjectArgs(sketchgui->getObject(),
"toggleConstruction(%d)",
getHighestCurveIndex());
}
editPoint.y,
isConstructionMode() ? "True" : "False");
Gui::Command::commitCommand();
}