kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Path: Drilling checks for bit size to determine drillability

Browse Source
This commit is contained in:
sliptonic
2017-03-19 14:05:07 -05:00
committed by Yorik van Havre
parent ffc4fb28aa
commit 8a3ac337f6
2 changed files with 33 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/Mod/Path/PathScripts/PathDrilling.py
View File

@@ -35,8 +35,8 @@ from PathScripts.PathUtils import fmt
LOG_MODULE = 'PathDrilling'
PathLog.setLevel(PathLog.Level.INFO, LOG_MODULE)
#PathLog.trackModule('PathDrilling')
PathLog.setLevel(PathLog.Level.DEBUG, LOG_MODULE)
PathLog.trackModule('PathDrilling')
FreeCADGui = None
if FreeCAD.GuiUp:
@@ -61,7 +61,7 @@ class ObjectDrilling:
# Base & location
obj.addProperty("App::PropertyLinkSubList", "Base","Path", QtCore.QT_TRANSLATE_NOOP("App::Property", "The base geometry of this toolpath"))
#obj.addProperty("App::PropertyVectorList", "Positions", "Tag", QtCore.QT_TRANSLATE_NOOP("PathDressup_HoldingTags", "Locations of insterted holding tags"))
obj.addProperty("App::PropertyIntegerList", "Disabled", "Tag", QtCore.QT_TRANSLATE_NOOP("PathDressup_HoldingTags", "Ids of disabled holding tags"))
obj.addProperty("App::PropertyIntegerList", "Disabled", "Path", QtCore.QT_TRANSLATE_NOOP("PathDressup_HoldingTags", "Ids of disabled holding tags"))
# General Properties
obj.addProperty("App::PropertyBool", "Active", "Path", QtCore.QT_TRANSLATE_NOOP("App::Property","Make False, to prevent operation from generating code"))
@@ -128,7 +128,7 @@ class ObjectDrilling:
baseobject = parentJob.Base
if baseobject is None:
return
holes = self.findHoles(baseobject.Shape)
holes = self.findHoles(obj, baseobject.Shape)
for hole in holes:
self.addDrillableLocation(obj, baseobject, hole[0])
@@ -198,25 +198,30 @@ class ObjectDrilling:
obj.Path = path
obj.ViewObject.Visibility = False
def findHoles(self, obj):
PathLog.track()
def findHoles(self, obj, shape):
import DraftGeomUtils as dgu
PathLog.track('obj: {} shape: {}'.format(obj, shape))
holelist = []
if obj.BoundBox.ZLength == 0:
for i in range(len(obj.Edges)):
tooldiameter = obj.ToolController.Proxy.getTool(obj.ToolController).Diameter
PathLog.debug('search for holes larger than tooldiameter: {}: '.format(tooldiameter))
if dgu.isPlanar(shape):
for i in range(len(shape.Edges)):
candidateEdgeName = "Edge" + str(i +1)
e = obj.getElement(candidateEdgeName)
if PathUtils.isDrillable(obj, e):
x = e.BoundBox.Center.x
y = e.BoundBox.Center.y
e = shape.getElement(candidateEdgeName)
if PathUtils.isDrillable(shape, e, tooldiameter):
PathLog.debug('edge candidate: {} is drillable '.format(e))
x = e.Curve.Center.x
y = e.Curve.Center.y
diameter = e.BoundBox.XLength
holelist.append((candidateEdgeName, e, x, y, diameter))
else:
for i in range(len(obj.Faces)):
for i in range(len(shape.Faces)):
candidateFaceName = "Face" + str(i + 1)
f = obj.getElement(candidateFaceName)
if PathUtils.isDrillable(obj, f):
x = f.BoundBox.Center.x
y = f.BoundBox.Center.y
f = shape.getElement(candidateFaceName)
if PathUtils.isDrillable(obj, f, tooldiameter):
PathLog.debug('face candidate: {} is drillable '.format(f))
x = f.Surface.Center.x
y = f.Surface.Center.y
diameter = f.BoundBox.XLength
holelist.append((candidateFaceName, f, x, y, diameter))

15
src/Mod/Path/PathScripts/PathUtils.py
View File

@@ -84,8 +84,8 @@ def curvetowire(obj, steps):
p0 = p
return edgelist
def isDrillable(obj, candidate):
PathLog.debug('obj: {} candidate {}')
def isDrillable(obj, candidate, tooldiameter=None):
PathLog.track('obj: {} candidate: {} tooldiameter {}'.format(obj, candidate, tooldiameter))
drillable = False
if candidate.ShapeType == 'Face':
face = candidate
@@ -107,7 +107,10 @@ def isDrillable(obj, candidate):
elif not hasattr(face.Surface, "Radius"): #abs(face.BoundBox.XLength - face.BoundBox.YLength) > 0.05:
drillable = False
else:
drillable = True
if tooldiameter is not None:
drillable = face.Surface.Radius >= tooldiameter/2
else:
drillable = True
else:
for edge in candidate.Edges:
if isinstance(edge.Curve, Part.Circle) and edge.isClosed():
@@ -117,7 +120,11 @@ def isDrillable(obj, candidate):
drillable = False
else:
PathLog.debug("Has Radius, Circle")
drillable = True
if tooldiameter is not None:
drillable = edge.Curve.Radius >= tooldiameter/2
else:
drillable = True
PathLog.debug("candidate is drillable: {}".format(drillable))
return drillable
# fixme set at 4 decimal places for testing