kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[TD]fix BrokenView selection (fix #16567)

Browse Source
This commit is contained in:
wandererfan
2024-09-18 12:30:40 -04:00
committed by Chris Hennes
parent a36a4b04e5
commit 8a4342e6e1
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Mod/TechDraw/Gui/Command.cpp
View File

@@ -559,6 +559,10 @@ void CmdTechDrawBrokenView::activated(int iMsg)
xShapesFromBase = dvp->XSource.getValues();
}
auto doc = getDocument();
if (dvp) {
doc = dvp->getDocument();
}
// get the shape objects from the selection
std::vector<App::DocumentObject*> shapes;
@@ -566,16 +570,17 @@ void CmdTechDrawBrokenView::activated(int iMsg)
App::DocumentObject* faceObj = nullptr;
std::string faceName;
getSelectedShapes(this, shapes, xShapes, faceObj, faceName);
shapes.insert(shapes.end(), shapesFromBase.begin(), shapesFromBase.end());
shapes.insert(xShapes.end(), xShapesFromBase.begin(), xShapesFromBase.end());
if (!dvp || (shapes.empty() && xShapes.empty())) {
// we need either a base view (dvp) or some shape objects in the selection
if (!dvp && (shapes.empty() && xShapes.empty())) {
QMessageBox::warning(Gui::getMainWindow(), QObject::tr("Empty selection"),
QObject::tr("Please select objects to break or a base view and break definition objects."));
return;
}
auto doc = dvp->getDocument();
shapes.insert(shapes.end(), shapesFromBase.begin(), shapesFromBase.end());
shapes.insert(xShapes.end(), xShapesFromBase.begin(), xShapesFromBase.end());
// pick the Break objects out of the selected pile
std::vector<Gui::SelectionObject> selection = getSelection().getSelectionEx(