kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[Part] Optimize snippet of code in ShapeMerge.py

Browse Source 
Some notes:

Earlier, when adding to the list `connected_to`. the numbers are added in order
from `range(len(groups)`, so we are already in order and every `i_group` is unique.
This commit is contained in:
Ajinkya Dahale
2023-01-01 01:49:08 +05:30
committed by Chris Hennes
parent 113bfed537
commit 8a44cfc970
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Mod/Part/BOPTools/ShapeMerge.py
View File

@@ -77,6 +77,7 @@ def splitIntoGroupsBySharing(list_of_shapes, element_extractor, split_connection
shape_elements.difference_update(split_connections)
#search if shape is connected to any groups
connected_to = []
not_in_connected_to = []
for iGroup in range(len(groups)):
connected = False
for element in shape_elements:
@@ -84,6 +85,10 @@ def splitIntoGroupsBySharing(list_of_shapes, element_extractor, split_connection
connected_to.append(iGroup)
connected = True
break
else:
# `break` not invoked, so `connected` is false
not_in_connected_to.append(iGroup)
# test if we need to join groups
if len(connected_to)>1:
#shape bridges a gap between some groups. Join them into one.
@@ -96,9 +101,10 @@ def splitIntoGroupsBySharing(list_of_shapes, element_extractor, split_connection
supergroup[1].update( groups[iGroup][1] )# merge lists of elements
groups_new.append(supergroup)
for iGroup in range(len(groups)):
if not iGroup in connected_to: #fixme: inefficient!
groups_new.append(groups[iGroup])
l_groups = len(groups)
groups_new.extend([groups[i_group] \
for i_group in not_in_connected_to \
if i_group < l_groups])
groups = groups_new
connected_to = [0]