kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Use QHash<K,T> instead of QMap<K,T> when K is a pointer. [-Wclazy-qmap-with-pointer-key] Thanks Clazy!

Browse Source
This commit is contained in:
Mateusz Skowroński
2019-01-30 20:33:25 +01:00
committed by wmayer
parent fbdfe16462
commit 92614e5688
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Gui/SceneInspector.cpp
View File

@@ -101,7 +101,7 @@ void SceneModel::setNode(QModelIndex index, SoNode* node)
SoNode* child = group->getChild(i);
setNode(this->index(i, 0, index), child);
QMap<SoNode*, QString>::iterator it = nodeNames.find(child);
QHash<SoNode*, QString>::iterator it = nodeNames.find(child);
if (it != nodeNames.end()) {
this->setData(this->index(i, 1, index), QVariant(it.value()));
}
@@ -113,7 +113,7 @@ void SceneModel::setNode(QModelIndex index, SoNode* node)
// insert icon
}
void SceneModel::setNodeNames(const QMap<SoNode*, QString>& names)
void SceneModel::setNodeNames(const QHash<SoNode*, QString>& names)
{
nodeNames = names;
}
@@ -173,7 +173,7 @@ void DlgInspector::setNodeNames(Gui::Document* doc)
{
std::vector<Gui::ViewProvider*> vps = doc->getViewProvidersOfType
(Gui::ViewProviderDocumentObject::getClassTypeId());
QMap<SoNode*, QString> nodeNames;
QHash<SoNode*, QString> nodeNames;
for (std::vector<Gui::ViewProvider*>::iterator it = vps.begin(); it != vps.end(); ++it) {
Gui::ViewProviderDocumentObject* vp = static_cast<Gui::ViewProviderDocumentObject*>(*it);
App::DocumentObject* obj = vp->getObject();

6
src/Gui/SceneInspector.h
View File

@@ -25,7 +25,7 @@
#include <QStandardItemModel>
#include <QDialog>
#include <QMap>
#include <QHash>
class SoNode;
@@ -56,13 +56,13 @@ public:
/// insert the first node in tree
void setNode(SoNode* node);
/// set names per node
void setNodeNames(const QMap<SoNode*, QString>& names);
void setNodeNames(const QHash<SoNode*, QString>& names);
/// returns standard parent's flags
Qt::ItemFlags flags (const QModelIndex & index) const;
private:
void setNode(QModelIndex, SoNode*);
QMap<SoNode*, QString> nodeNames;
QHash<SoNode*, QString> nodeNames;
};
/// Dialog window to display scenegraph model as a tree