kindred/create
1
1
Fork 0
Code Issues 43 Pull Requests 1 Actions 3 Packages Projects 9 Releases 2 Wiki Activity

Part: [skip ci] fix crash when trying to scale null shape

Browse Source
This commit is contained in:
wmayer
2020-10-09 08:31:48 +02:00
parent 12b6dd955b
commit 93a331c3ba
1 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/Mod/Part/App/TopoShapePyImp.cpp
View File

@@ -1492,7 +1492,7 @@ PyObject* TopoShapePy::scale(PyObject *args)
double factor;
PyObject* p=0;
if (!PyArg_ParseTuple(args, "d|O!", &factor, &(Base::VectorPy::Type), &p))
return NULL;
return nullptr;
gp_Pnt pos(0,0,0);
if (p) {
@@ -1502,17 +1502,20 @@ PyObject* TopoShapePy::scale(PyObject *args)
pos.SetZ(pnt.z);
}
if (fabs(factor) < Precision::Confusion()) {
PyErr_SetString(PartExceptionOCCError, "scale factor too small");
return NULL;
PyErr_SetString(PyExc_ValueError, "scale factor too small");
return nullptr;
}
PY_TRY {
gp_Trsf scl;
scl.SetScale(pos, factor);
BRepBuilderAPI_Transform BRepScale(scl);
bool bCopy = true;
BRepScale.Perform(getTopoShapePtr()->getShape(),bCopy);
getTopoShapePtr()->setShape(BRepScale.Shape());
const TopoDS_Shape& shape = getTopoShapePtr()->getShape();
if (!shape.IsNull()) {
gp_Trsf scl;
scl.SetScale(pos, factor);
BRepBuilderAPI_Transform BRepScale(scl);
bool bCopy = true;
BRepScale.Perform(shape, bCopy);
getTopoShapePtr()->setShape(BRepScale.Shape());
}
return IncRef();
} PY_CATCH_OCC
}