kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Sketcher: fix crash in CmdRenderingOrder::updateIcon()

Browse Source 
If a parameter in the observed parameter group is changed then CmdRenderingOrder::OnChange() is called but the ActionGroup may not be created yet
This commit is contained in:
wmayer
2024-04-17 19:41:15 +02:00
committed by wwmayer
parent 83abfa49b8
commit 95df9e3244
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/Mod/Sketcher/Gui/Command.cpp
View File

@@ -1771,16 +1771,16 @@ void CmdRenderingOrder::updateIcon()
Gui::BitmapFactory().iconFromTheme("Sketcher_RenderingOrder_Construction");
static QIcon external = Gui::BitmapFactory().iconFromTheme("Sketcher_RenderingOrder_External");
auto* pcAction = qobject_cast<Gui::ActionGroup*>(getAction());
if (TopElement == ElementType::Normal) {
pcAction->setIcon(normal);
}
else if (TopElement == ElementType::Construction) {
pcAction->setIcon(construction);
}
else if (TopElement == ElementType::External) {
pcAction->setIcon(external);
if (auto* pcAction = qobject_cast<Gui::ActionGroup*>(getAction())) {
if (TopElement == ElementType::Normal) {
pcAction->setIcon(normal);
}
else if (TopElement == ElementType::Construction) {
pcAction->setIcon(construction);
}
else if (TopElement == ElementType::External) {
pcAction->setIcon(external);
}
}
}