kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[PD] TaskExtrudeParameters: simplify code

Browse Source 
to avoid several time the same translatable string
This commit is contained in:
Uwe
2022-07-20 03:16:56 +02:00
parent 0e22ada9dd
commit 98dae1b217
4 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp
View File

@@ -50,7 +50,7 @@ TaskExtrudeParameters::TaskExtrudeParameters(ViewProviderSketchBased *SketchBase
// we need a separate container widget to add all controls to // we need a separate container widget to add all controls to
proxy = new QWidget(this); proxy = new QWidget(this);
ui->setupUi(proxy); ui->setupUi(proxy);
ui->lineFaceName->setPlaceholderText(tr("No face selected")); handleLineFaceNameNo();
Gui::ButtonGroup* group = new Gui::ButtonGroup(this); Gui::ButtonGroup* group = new Gui::ButtonGroup(this);
group->addButton(ui->checkBoxMidplane); group->addButton(ui->checkBoxMidplane);
@@ -683,10 +683,10 @@ void TaskExtrudeParameters::getReferenceAxis(App::DocumentObject*& obj, std::vec
void TaskExtrudeParameters::onButtonFace(const bool checked) void TaskExtrudeParameters::onButtonFace(const bool checked)
{ {
if (!checked && ui->lineFaceName->text().isEmpty()) if (!checked)
ui->lineFaceName->setPlaceholderText(tr("No face selected")); handleLineFaceNameNo();
else if (checked && ui->lineFaceName->text().isEmpty()) else
handleLineFaceName(); // sets placeholder text handleLineFaceNameClick(); // sets placeholder text
// to distinguish that this is the direction selection // to distinguish that this is the direction selection
selectionFace = true; selectionFace = true;
@@ -892,9 +892,14 @@ void TaskExtrudeParameters::translateModeList(int)
// implement in sub-class // implement in sub-class
} }
void TaskExtrudeParameters::handleLineFaceName(void) void TaskExtrudeParameters::handleLineFaceNameClick(void)
{ {
ui->lineFaceName->setPlaceholderText(tr("Click on a face in the model")); ui->lineFaceName->setPlaceholderText(tr("Click on a face in the model"));
} }
void TaskExtrudeParameters::handleLineFaceNameNo(void)
{
ui->lineFaceName->setPlaceholderText(tr("No face selected"));
}
#include "moc_TaskExtrudeParameters.cpp" #include "moc_TaskExtrudeParameters.cpp"

3
src/Mod/PartDesign/Gui/TaskExtrudeParameters.h
View File

@@ -118,7 +118,8 @@ protected:
virtual void updateUI(int index); virtual void updateUI(int index);
void updateDirectionEdits(void); void updateDirectionEdits(void);
void setDirectionMode(int index); void setDirectionMode(int index);
void handleLineFaceName(void); void handleLineFaceNameClick(void);
void handleLineFaceNameNo(void);
private: private:
void tryRecomputeFeature(); void tryRecomputeFeature();

2
src/Mod/PartDesign/Gui/TaskPadParameters.cpp
View File

@@ -106,7 +106,7 @@ void TaskPadParameters::onModeChanged(int index)
pcPad->Type.setValue("UpToFace"); pcPad->Type.setValue("UpToFace");
if (ui->lineFaceName->text().isEmpty()) { if (ui->lineFaceName->text().isEmpty()) {
ui->buttonFace->setChecked(true); ui->buttonFace->setChecked(true);
handleLineFaceName(); // sets placeholder text handleLineFaceNameClick(); // sets placeholder text
} }
break; break;
case Modes::TwoDimensions: case Modes::TwoDimensions:

2
src/Mod/PartDesign/Gui/TaskPocketParameters.cpp
View File

@@ -116,7 +116,7 @@ void TaskPocketParameters::onModeChanged(int index)
ui->lengthEdit->setValue(0.0); ui->lengthEdit->setValue(0.0);
if (ui->lineFaceName->text().isEmpty()) { if (ui->lineFaceName->text().isEmpty()) {
ui->buttonFace->setChecked(true); ui->buttonFace->setChecked(true);
handleLineFaceName(); // sets placeholder text handleLineFaceNameClick(); // sets placeholder text
} }
break; break;
case Modes::TwoDimensions: case Modes::TwoDimensions: