kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PD: Improve error handling for RevolMethod::ToFirst

Browse Source
This commit is contained in:
Chris Hennes
2026-02-09 09:08:45 -06:00
committed by Kacper Donat
parent 1752fd59f9
commit 9e042ff480
3 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/Mod/PartDesign/App/FeatureGroove.cpp
View File

@@ -194,9 +194,8 @@ App::DocumentObjectExecReturn* Groove::execute()
upToFace.move(invObjLoc);
}
else {
throw Base::RuntimeError(
"ProfileBased: Revolution up to first/last is not yet supported"
);
// TODO: Implement finding the first face this revolution would intersect with
return new App::DocumentObjectExecReturn("Groove up to first is not yet supported");
}
if (Reversed.getValue()) {

5
src/Mod/PartDesign/App/FeatureRevolution.cpp
View File

@@ -216,9 +216,8 @@ App::DocumentObjectExecReturn* Revolution::execute()
upToFace.move(invObjLoc);
}
else {
throw Base::RuntimeError(
"ProfileBased: Revolution up to first/last is not yet supported"
);
// TODO: Implement finding the first face this revolution would intersect with
return new App::DocumentObjectExecReturn("Revolve up to first is not yet supported");
}
if (Reversed.getValue()) {

12
src/Mod/PartDesign/Gui/TaskRevolutionParameters.cpp
View File

@@ -46,6 +46,8 @@
#include "ViewProviderRevolution.h"
#include "ReferenceSelection.h"
#include <QStandardItemModel>
using namespace PartDesignGui;
using namespace Gui;
@@ -202,6 +204,16 @@ void TaskRevolutionParameters::translateModeList(int index)
ui->changeMode->addItem(tr("Through all"));
}
ui->changeMode->addItem(tr("To first"));
// "To first" is not available for revolutions right now, but if we just don't add it, the index
// will be wrong. So disable it instead. Messy workaround for #27403
auto toFirstIndex = ui->changeMode->count() - 1;
auto* model = qobject_cast<QStandardItemModel*>(ui->changeMode->model());
if (model) {
QStandardItem* item = model->item(toFirstIndex);
item->setFlags(item->flags() & ~Qt::ItemIsEnabled);
}
ui->changeMode->addItem(tr("Up to face"));
ui->changeMode->addItem(tr("Two angles"));
ui->changeMode->setCurrentIndex(index);