kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: fix warning -Wunused-parameter

Browse Source 
The function PropertyEditor::recomputeDocument() accepts a pointer to App::Document that is passed by the calling instance closeTransaction().
Since this is the active document there is no need for PropertyEditor::recomputeDocument() to ignore the argument and determine the active document again.
This commit is contained in:
wmayer
2022-02-21 15:41:28 +01:00
parent 7b7a0aa4bf
commit ae2331b316
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Gui/propertyeditor/PropertyEditor.cpp
View File

@@ -307,13 +307,11 @@ void PropertyEditor::onItemActivated ( const QModelIndex & index )
void PropertyEditor::recomputeDocument(App::Document* doc)
{
try {
if (App::Document* doc = App::GetApplication().getActiveDocument()) {
if (!doc->isTransactionEmpty()) {
// Between opening and committing a transaction a recompute
// could already have been done
if (doc->isTouched())
doc->recompute();
}
if (doc && !doc->isTransactionEmpty()) {
// Between opening and committing a transaction a recompute
// could already have been done
if (doc->isTouched())
doc->recompute();
}
}
// do not re-throw