kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Path: [skip ci] Fix several clazy issues:

Browse Source 
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
This commit is contained in:
wmayer
2022-07-25 12:21:32 +02:00
parent a9a4cf3d6d
commit af71685a50
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Mod/Path/App/Area.cpp
View File

@@ -210,7 +210,7 @@ Area::Area(const Area& other, bool deep_copy)
myShape = other.myShape;
myShapeDone = other.myShapeDone;
mySections.reserve(other.mySections.size());
for (shared_ptr<Area> area : other.mySections)
for (const shared_ptr<Area>& area : other.mySections)
mySections.push_back(make_shared<Area>(*area, true));
}

4
src/Mod/Path/libarea/Adaptive.cpp
View File

@@ -1794,7 +1794,7 @@ std::list<AdaptiveOutput> Adaptive2d::Execute(const DPaths &stockPaths, const DP
if (opType == OperationType::otClearingOutside)
{
// add stock paths, with overshooting
for (auto p : stockOvershoot)
for (const auto& p : stockOvershoot)
inputPaths.push_back(p);
}
else if (opType == OperationType::otClearingInside)
@@ -2639,7 +2639,7 @@ void Adaptive2d::ProcessPolyNode(Paths boundPaths, Paths toolBoundPaths)
clipof.Execute(outsideEngage, toolRadiusScaled - stepOverFactor * toolRadiusScaled);
CleanPolygons(outsideEngage);
ReversePaths(outsideEngage);
for (auto p : outsideEngage)
for (const auto& p : outsideEngage)
engageBounds.push_back(p);
outsideEntry = true;
}

4
src/Mod/Path/libarea/AreaOrderer.cpp
View File

@@ -77,14 +77,14 @@ void CInnerCurves::Insert(shared_ptr<CCurve> pcurve)
shared_ptr<CInnerCurves> new_item(new CInnerCurves(shared_from_this(), pcurve));
this->m_inner_curves.insert(new_item);
for(shared_ptr<CInnerCurves> c : outside_of_these) {
for(const shared_ptr<CInnerCurves>& c : outside_of_these) {
// move items
c->m_pOuter = new_item;
new_item->m_inner_curves.insert(c);
this->m_inner_curves.erase(c);
}
for(shared_ptr<CInnerCurves> c : crossing_these) {
for(const shared_ptr<CInnerCurves>& c : crossing_these) {
// unite these
new_item->Unite(c);
this->m_inner_curves.erase(c);