kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PartDesign: Hole: fallback to getProfileNormal when a non-cylindrical surface is used

Browse Source
This commit is contained in:
theo-vt
2025-08-14 13:27:08 -04:00
committed by Chris Hennes
parent a0705f1d85
commit af83b6883e
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Mod/PartDesign/App/FeatureHole.cpp
View File

@@ -2266,12 +2266,10 @@ Base::Vector3d Hole::guessNormalDirection(const TopoShape& profileshape) const
// the middle of the face
if (profileshape.hasSubShape(TopAbs_FACE)) {
BRepAdaptor_Surface sf(TopoDS::Face(profileshape.getSubShape(TopAbs_FACE, 1)));
if (sf.GetType() != GeomAbs_Cylinder) {
throw Base::Exception("Cannot create hole from non cylindrical face");
if (sf.GetType() == GeomAbs_Cylinder) {
return Base::convertTo<Base::Vector3d>(sf.Cylinder().Axis().Direction());
}
return Base::convertTo<Base::Vector3d>(sf.Cylinder().Axis().Direction());
}
return getProfileNormal();