kindred/create
1
1
Fork 0
Code Issues 34 Pull Requests Actions 4 Packages Projects 9 Releases 2 Wiki Activity

Part: optimize hasShapesInSelection() by avoiding performing a possibly expensive transformation

Browse Source 
See also: https://forum.freecadweb.org/viewtopic.php?p=592445#p592445
This commit is contained in:
wmayer
2022-05-02 17:19:49 +02:00
parent ea5f3eb68e
commit afebe07514
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/Mod/Part/Gui/Command.cpp
View File

@@ -277,7 +277,8 @@ bool hasShapesInSelection()
bool hasShapes = false;
std::vector<App::DocumentObject*> docobjs = Gui::Selection().getObjectsOfType(App::DocumentObject::getClassTypeId());
for (std::vector<App::DocumentObject*>::iterator it = docobjs.begin(); it != docobjs.end(); ++it) {
if (!Part::Feature::getTopoShape(*it).isNull()) {
// Only check for the existence of a shape but don't perform a transformation
if (!Part::Feature::getTopoShape(*it, nullptr, false, nullptr, nullptr, true, false, false).isNull()) {
hasShapes = true;
break;
}
@@ -1302,7 +1303,7 @@ void CmdPartReverseShape::activated(int iMsg)
bool CmdPartReverseShape::isActive(void)
{
return PartGui::getShapesFromSelection().size() > 0;
return PartGui::hasShapesInSelection();
}
//===========================================================================