kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Help: Fix function return to avoid error when clicking URL on built-in browser (#17498)

Browse Source 
* Help: Fix function return to avoid error when clicking URL on built-in browser

* fixup! Help: Fix function return to avoid error when clicking URL on built-in browser

Co-authored-by: Yorik van Havre <yorik.vanhavre@gmail.com>

---------

Co-authored-by: Yorik van Havre <yorik.vanhavre@gmail.com>
This commit is contained in:
Ulices
2024-10-30 11:51:45 +00:00
committed by GitHub
parent 4f323f9580
commit b6cda4309a
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/Mod/Help/Help.py
View File

@@ -160,15 +160,20 @@ def location_url(url_localized: str, url_english: str) -> tuple:
"""
Returns localized documentation url and page name, if they exist,
otherwise defaults to english version.
Page name is gotten from:
a) Name/* metadata tag on raw markdown files from github,
Wiki translators should make sure to add it.
b) <title> HTML tag
"""
try:
req = urllib.request.Request(url_localized)
with urllib.request.urlopen(req) as response:
html = response.read().decode("utf-8")
if re.search(r"https://wiki.freecad.org", url_localized):
pagename_match = re.search(r"<title>(.*?) - .*?</title>", html)
else:
if re.search(MD_RAW_URL, url_localized):
pagename_match = re.search(r"Name/.*?:\s*(.+)", html)
else:
# Pages from FreeCAD Wiki fall here
pagename_match = re.search(r"<title>(.*?) - .*?</title>", html)
if pagename_match is not None:
return (url_localized, pagename_match.group(1))
else:
@@ -177,17 +182,19 @@ def location_url(url_localized: str, url_english: str) -> tuple:
return (url_english, "")
def get_location(page):
"""retrieves the location (online or offline) of a given page"""
def get_location(page) -> tuple:
"""retrieves the location (online or offline) of a given page. Returns the location and the page name"""
location = ""
if page.startswith("http"):
return page
# NOTE: This gets activated when you open a link on the built-in browser, since
# we don't know the URL, using location_url() fallback to the HTML <title> tag
return location_url(page, page)
if page.startswith("file://"):
return page[7:]
return (page[7:], "")
# offline location
if os.path.exists(page):
return page
return (page, "")
page = page.replace(".md", "")
page = page.replace(" ", "_")
page = page.replace("wiki/", "")