kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Part: Remove inefficient vector reserve()

Browse Source 
Coverity issue 356645
This commit is contained in:
Chris Hennes
2025-03-20 22:22:16 -05:00
committed by Benjamin Nauck
parent 03bbcaf30d
commit b8589b03ea
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/Mod/Part/App/modelRefine.cpp
View File

@@ -1071,8 +1071,13 @@ bool FaceUniter::process()
checkFinalShell = true;
}
facesToSew.push_back(newFace);
if (facesToRemove.capacity() <= facesToRemove.size() + adjacencySplitter.getGroup(adjacentIndex).size())
facesToRemove.reserve(facesToRemove.size() + adjacencySplitter.getGroup(adjacentIndex).size());
// This reserve is probably not actually an improvement over letting
// emplace_back allocate as needed. Leaving the code here for study if someone
// wants to measure it. Coverity issue 356645. - chennes, March 2025
//if (facesToRemove.capacity() <= facesToRemove.size() + adjacencySplitter.getGroup(adjacentIndex).size())
// facesToRemove.reserve(facesToRemove.size() + adjacencySplitter.getGroup(adjacentIndex).size());
FaceVectorType temp = adjacencySplitter.getGroup(adjacentIndex);
facesToRemove.insert(facesToRemove.end(), temp.begin(), temp.end());
// the first shape will be marked as modified, i.e. replaced by newFace, all others are marked as deleted