kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Robot: [skip ci] Fix several clazy issues:

Browse Source 
* Using copy-ctor but class KDL::Rotation has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Maybe you meant to call ViewProviderGeometryObject::attach() instead [-Wclazy-skipped-base-method]
* Missing emit keyword on signal call RobotGui::TaskTrajectory::axisChanged [-Wclazy-incorrect-emit]
This commit is contained in:
wmayer
2022-07-25 11:02:30 +02:00
parent 56730b0a2f
commit bbe617614b
7 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/Mod/Robot/App/kdl_cp/frameacc.hpp
View File

@@ -25,6 +25,7 @@
* $Id: rrframes.h,v 1.1.1.1 2002/08/26 14:14:21 rmoreas Exp $
* $Name: $
****************************************************************************/
// clazy:excludeall=rule-of-two-soft
#ifndef RRFRAMES_H
#define RRFRAMES_H

1
src/Mod/Robot/App/kdl_cp/frames.inl
View File

@@ -24,6 +24,7 @@
* Suite 330, Boston, MA 02111-1307 USA *
* *
***************************************************************************/
// clazy:excludeall=rule-of-two-soft
/**
* \file frames.inl

1
src/Mod/Robot/App/kdl_cp/framevel.hpp
View File

@@ -19,6 +19,7 @@
* $Id: rframes.h,v 1.1.1.1 2002/08/26 14:14:21 rmoreas Exp $
* $Name: $
****************************************************************************/
// clazy:excludeall=rule-of-two-soft
#ifndef KDL_FRAMEVEL_H
#define KDL_FRAMEVEL_H

1
src/Mod/Robot/App/kdl_cp/path_circle.cpp
View File

@@ -38,6 +38,7 @@
* $Id: path_circle.cpp,v 1.1.1.1.2.5 2003/07/24 13:26:15 psoetens Exp $
* $Name: $
****************************************************************************/
// clazy:excludeall=rule-of-two-soft
#include "path_circle.hpp"

1
src/Mod/Robot/App/kdl_cp/path_line.cpp
View File

@@ -38,6 +38,7 @@
* $Id: path_line.cpp,v 1.1.1.1.2.3 2003/07/24 13:26:15 psoetens Exp $
* $Name: $
****************************************************************************/
// clazy:excludeall=rule-of-two-soft
#include "path_line.hpp"

2
src/Mod/Robot/Gui/TaskTrajectory.cpp
View File

@@ -139,7 +139,7 @@ void TaskTrajectory::setTo(void)
sim.setToTime(timePos);
}
ViewProv->setAxisTo(sim.Axis[0],sim.Axis[1],sim.Axis[2],sim.Axis[3],sim.Axis[4],sim.Axis[5],sim.Rob.getTcp());
axisChanged(sim.Axis[0],sim.Axis[1],sim.Axis[2],sim.Axis[3],sim.Axis[4],sim.Axis[5],sim.Rob.getTcp());
Q_EMIT axisChanged(sim.Axis[0],sim.Axis[1],sim.Axis[2],sim.Axis[3],sim.Axis[4],sim.Axis[5],sim.Rob.getTcp());
viewTool(sim.Rob.getTcp());
}

2
src/Mod/Robot/Gui/ViewProviderTrajectory.cpp
View File

@@ -96,7 +96,7 @@ ViewProviderTrajectory::~ViewProviderTrajectory()
void ViewProviderTrajectory::attach(App::DocumentObject *pcObj)
{
ViewProviderDocumentObject::attach(pcObj);
ViewProviderGeometryObject::attach(pcObj);
// Draw trajectory lines
SoSeparator* linesep = new SoSeparator;