kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[TechDraw] Improve CosmeticVertex.cpp typing

Browse Source 
Make type safe by using const keywords when appropriate and improve memory handling by using references when appropriate.
This commit is contained in:
Benjamin Bræstrup Sayoc
2023-07-17 14:19:25 +02:00
committed by WandererFan
parent 7c7823dd9b
commit bef32983b0
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Mod/TechDraw/App/CosmeticVertex.cpp
View File

@@ -71,7 +71,7 @@ CosmeticVertex::CosmeticVertex(const TechDraw::CosmeticVertex* cv) : TechDraw::V
createNewTag();
}
CosmeticVertex::CosmeticVertex(Base::Vector3d loc) : TechDraw::Vertex(loc)
CosmeticVertex::CosmeticVertex(const Base::Vector3d& loc) : TechDraw::Vertex(loc)
{
permaPoint = loc;
linkGeom = -1;
@@ -87,12 +87,12 @@ CosmeticVertex::CosmeticVertex(Base::Vector3d loc) : TechDraw::Vertex(loc)
}
void CosmeticVertex::move(Base::Vector3d newPos)
void CosmeticVertex::move(const Base::Vector3d& newPos)
{
permaPoint = newPos;
}
void CosmeticVertex::moveRelative(Base::Vector3d movement)
void CosmeticVertex::moveRelative(const Base::Vector3d& movement)
{
permaPoint += movement;
}
@@ -172,7 +172,7 @@ void CosmeticVertex::Restore(Base::XMLReader &reader)
tag = u1;
}
Base::Vector3d CosmeticVertex::scaled(double factor)
Base::Vector3d CosmeticVertex::scaled(const double factor)
{
return permaPoint * factor;
}
@@ -202,7 +202,7 @@ void CosmeticVertex::createNewTag()
tag = gen();
}
void CosmeticVertex::assignTag(const TechDraw::CosmeticVertex * cv)
void CosmeticVertex::assignTag(const TechDraw::CosmeticVertex* cv)
{
if(cv->getTypeId() == this->getTypeId())
this->tag = cv->tag;
@@ -233,7 +233,7 @@ PyObject* CosmeticVertex::getPyObject()
return Py::new_reference_to(PythonObject);
}
// To do: make const
void CosmeticVertex::dump(const char* title)
{
Base::Console().Message("CV::dump - %s \n", title);

8
src/Mod/TechDraw/App/CosmeticVertex.h
View File

@@ -44,15 +44,15 @@ class TechDrawExport CosmeticVertex: public Base::Persistence, public TechDraw::
public:
CosmeticVertex();
CosmeticVertex(const CosmeticVertex* cv);
CosmeticVertex(Base::Vector3d loc);
CosmeticVertex(const Base::Vector3d& loc);
~CosmeticVertex() override = default;
void move(Base::Vector3d newPos);
void moveRelative(Base::Vector3d movement);
void move(const Base::Vector3d& newPos);
void moveRelative(const Base::Vector3d& movement);
std::string toString() const;
void dump(const char* title) override;
Base::Vector3d scaled(double factor);
Base::Vector3d scaled(const double factor);
static bool restoreCosmetic();