kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PartDesign: Update Length/Offset when Occurrences changes (#12069)

Browse Source 
* Add 'HACK:'/`NOTE:` tags to get special highlightning

* [PD] Bugfix: Update Length/Offset when Occurrences changes

Fix #12068
This commit is contained in:
Ulices
2024-01-21 18:52:34 -06:00
committed by GitHub
parent 5b7cca7703
commit bf7adc51d1
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Mod/PartDesign/App/FeatureLinearPattern.cpp
View File

@@ -221,7 +221,7 @@ const std::list<gp_Trsf> LinearPattern::getTransformations(const std::vector<App
gp_Trsf trans;
transformations.push_back(trans);
// Note: The original feature is already included in the list of transformations!
// NOTE: The original feature is already included in the list of transformations!
// Therefore we start with occurrence number 1
for (int i = 1; i < occurrences; i++) {
trans.SetTranslation(offset * i);
@@ -254,12 +254,14 @@ void LinearPattern::onChanged(const App::Property* prop)
setReadWriteStatusForMode(mode);
}
// Keep Length in sync with Offset
if (mode == LinearPatternMode::offset && prop == &Offset && !Length.testStatus(App::Property::Status::Immutable)) {
// Keep Length in sync with Offset, catch Occurrences changes
if (mode == LinearPatternMode::offset && (prop == &Offset || prop == &Occurrences)
&& !Length.testStatus(App::Property::Status::Immutable)) {
Length.setValue(Offset.getValue() * (Occurrences.getValue() - 1));
}
if (mode == LinearPatternMode::length && prop == &Length && !Offset.testStatus(App::Property::Status::Immutable)) {
if (mode == LinearPatternMode::length && (prop == &Length || prop == &Occurrences)
&& !Offset.testStatus(App::Property::Status::Immutable)) {
Offset.setValue(Length.getValue() / (Occurrences.getValue() - 1));
}

2
src/Mod/PartDesign/WizardShaft/WizardShaft.py
View File

@@ -169,7 +169,7 @@ class TaskWizardShaft:
def isAllowedAlterDocument(self):
return False
# Workaround to allow a callback
# HACK: Workaround to allow a callback
# Problem: From the FemConstraint ViewProvider, we need to tell the Shaft instance that the user finished editing the constraint
# We can find the Shaft Wizard dialog object from C++, but there is no way to reach the Shaft instance
# Also it seems to be impossible to access the active dialog from Python, so Gui::Command::runCommand() is not an option either