kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PartDesign: [skip ci] make the hole feature more forgiving in case of inconsistent configuration

Browse Source
This commit is contained in:
wmayer
2020-10-19 14:42:32 +02:00
parent 39744ce987
commit c0b2188ada
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Mod/PartDesign/App/FeatureHole.cpp
View File

@@ -592,8 +592,11 @@ void Hole::updateDiameterParam()
void Hole::onChanged(const App::Property *prop)
{
if (prop == &ThreadType) {
std::string type(ThreadType.getValueAsString());
std::string holeCutType(HoleCutType.getValueAsString());
std::string type, holeCutType;
if (ThreadType.isValid())
type = ThreadType.getValueAsString();
if (HoleCutType.isValid())
holeCutType = HoleCutType.getValueAsString();
if (type == "None" ) {
ThreadSize.setEnums(ThreadSize_None_Enums);
@@ -802,8 +805,11 @@ void Hole::onChanged(const App::Property *prop)
updateDiameterParam();
}
else if (prop == &HoleCutType) {
std::string threadType = ThreadType.getValueAsString();
std::string holeCutType = HoleCutType.getValueAsString();
std::string threadType, holeCutType;
if (ThreadType.isValid())
threadType = ThreadType.getValueAsString();
if (HoleCutType.isValid())
holeCutType = HoleCutType.getValueAsString();
bool holeCutEnable = ( threadType != "ISOMetricProfile" &&
threadType !="ISOMetricFineProfile" &&
(holeCutType != "None"));