kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PartDesign: fix helix with negative angle

Browse Source
This commit is contained in:
Florian Foinant-Willig
2024-12-03 22:31:16 +01:00
committed by Chris Hennes
parent d1f706050d
commit c4528eb3a5
2 changed files with 45 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Mod/PartDesign/App/FeatureHelix.cpp
View File

@@ -408,8 +408,7 @@ TopoDS_Shape Helix::generateHelixPath(double breakAtTurn)
bool turned = axisOffset < 0;
// since the factor does not only change the radius but also the path position, we must shift its offset back
// using the square of the factor
double noAngle = angle == 0. ? 1. : 0.; // alternative to the legacy use of an auxiliary path
double startOffset = 10000.0 * std::fabs(noAngle * (profileCenter * axisVector) - baseVector * axisVector);
double startOffset = 10000.0 * std::fabs((angle <= 0. ? 1. : 0.) * (profileCenter * axisVector) - baseVector * axisVector);
if (radius < Precision::Confusion()) {
// in this case ensure that axis is not in the sketch plane

44
src/Mod/PartDesign/PartDesignTests/TestHelix.py
View File

@@ -317,6 +317,50 @@ class TestHelix(unittest.TestCase):
self.Doc.recompute()
self.assertAlmostEqual(helix.Shape.Volume/1e5, 3.8828,places=4)
def testNegativeCone(self):
""" Test helix following a cone with a negative angle """
body = self.Doc.addObject('PartDesign::Body','ConeBody')
coneSketch = self.Doc.addObject('Sketcher::SketchObject', 'ConeSketch')
body.addObject(coneSketch)
geoList = []
geoList.append(Part.LineSegment(FreeCAD.Vector(5, 5, 0), FreeCAD.Vector(3, 0, 0)))
geoList.append(Part.LineSegment(FreeCAD.Vector(3, 0, 0), FreeCAD.Vector(2, 0, 0)))
geoList.append(Part.LineSegment(FreeCAD.Vector(2, 0, 0), FreeCAD.Vector(4, 5, 0)))
geoList.append(Part.LineSegment(FreeCAD.Vector(4, 5, 0), FreeCAD.Vector(5, 5, 0)))
(l1, l2, l3, l4) = coneSketch.addGeometry(geoList)
conList = []
conList.append(Sketcher.Constraint("Coincident", 0, 2, 1, 1))
conList.append(Sketcher.Constraint("Coincident", 1, 2, 2, 1))
conList.append(Sketcher.Constraint("Coincident", 2, 2, 3, 1))
conList.append(Sketcher.Constraint("Coincident", 3, 2, 0, 1))
conList.append(Sketcher.Constraint("Horizontal", 1))
conList.append(Sketcher.Constraint("Angle", l3, 1, -2, 2, FreeCAD.Units.Quantity("30 deg")))
conList.append(Sketcher.Constraint("DistanceX", 1, 2, -100))
conList.append(Sketcher.Constraint("DistanceY", 1, 2, 0))
conList.append(Sketcher.Constraint("Equal", 0, 2))
conList.append(Sketcher.Constraint("Equal", 1, 3))
conList.append(Sketcher.Constraint("DistanceY", 0, 50))
conList.append(Sketcher.Constraint("DistanceX", 1, 10))
coneSketch.addConstraint(conList)
xz_plane = body.Origin.OriginFeatures[4]
coneSketch.AttachmentSupport = xz_plane
coneSketch.MapMode = 'FlatFace'
helix = self.Doc.addObject("PartDesign::AdditiveHelix", "AdditiveHelix")
body.addObject(helix)
helix.Profile = coneSketch
helix.ReferenceAxis = (coneSketch, "V_Axis")
helix.Pitch = 50
helix.Height = 110
helix.Angle = -30
helix.Mode = 0
helix.Reversed = False
self.Doc.recompute()
self.assertAlmostEqual(helix.Shape.Volume/1e5, 6.0643, places=4)
def tearDown(self):
FreeCAD.closeDocument("PartDesignTestHelix")