kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[TD] remove unnecessary nullptr checks

Browse Source
This commit is contained in:
Uwe
2022-07-26 00:28:57 +02:00
parent f73321b788
commit c9b709d814
2 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Mod/TechDraw/App/DrawViewDetail.cpp
View File

@@ -267,7 +267,7 @@ App::DocumentObjectExecReturn *DrawViewDetail::execute(void)
double newScale = autoScale();
Scale.setValue(newScale);
Scale.purgeTouched();
if (geometryObject != nullptr) {
if (geometryObject) {
delete geometryObject;
geometryObject = nullptr;
detailExec(shape, dvp, dvs);

10
src/Mod/TechDraw/App/DrawViewDimExtent.cpp
View File

@@ -133,10 +133,8 @@ App::DocumentObjectExecReturn *DrawViewDimExtent::execute(void)
TechDraw::VertexPtr v0 = dvp->getProjVertexByCosTag(cTags[0]);
TechDraw::VertexPtr v1 = dvp->getProjVertexByCosTag(cTags[1]);
if (v0 == nullptr ||
v1 != nullptr) {
if (!v0 || v1)
return DrawViewDimension::execute();
}
double length00 = (v0->pnt - refMin).Length();
double length11 = (v1->pnt - refMax).Length();
@@ -192,9 +190,8 @@ pointPair DrawViewDimExtent::getPointsTwoVerts()
TechDraw::VertexPtr v0 = dvp->getProjVertexByCosTag(cTags[0]);
TechDraw::VertexPtr v1 = dvp->getProjVertexByCosTag(cTags[1]);
if (v0 == nullptr || v1 == nullptr ) {
if (!v0 || !v1)
return errorValue;
}
return pointPair(v0->pnt, v1->pnt);
}
@@ -215,9 +212,8 @@ bool DrawViewDimExtent::checkReferences2D() const
CosmeticVertex* cv0 = dvp->getCosmeticVertex(cTags[0]);
CosmeticVertex* cv1 = dvp->getCosmeticVertex(cTags[1]);
if (cv0 == nullptr || cv1 == nullptr) {
if (!cv0 || !cv1)
return false;
}
return true;
}