kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: Eliminate double->float truncations

Browse Source 
Our GUI code uses a mix of floats and doubles to represent floating
point numbers, and in a few places interchanges them in a way that
causes an invisible loss of precision. Change the double precision
"default" values to float defaults, and use the appropriate value for
pi.
This commit is contained in:
Chris Hennes
2025-05-12 23:45:20 -05:00
committed by Kacper Donat
parent 305ef46e2c
commit c9c193b5d6
3 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/Gui/Inventor/SoFCPlacementIndicatorKit.h
View File

@@ -33,21 +33,21 @@ namespace Gui {
class GuiExport SoFCPlacementIndicatorKit : public SoBaseKit {
using inherited = SoBaseKit;
static constexpr double planeIndicatorRadius = 0.4f;
static constexpr double planeIndicatorMargin = 0.2f;
static constexpr double planeIndicatorTransparency = 0.3f;
static constexpr float planeIndicatorRadius = 0.4F;
static constexpr double planeIndicatorMargin = 0.2;
static constexpr float planeIndicatorTransparency = 0.3F;
static constexpr double axisMargin = 0.0f;
static constexpr double axisLengthDefault = 0.6f;
static constexpr double axisThickness = 0.065f;
static constexpr double axisMargin = 0.0;
static constexpr float axisLengthDefault = 0.6F;
static constexpr float axisThickness = 0.065F;
static constexpr double arrowHeadRadius = axisThickness * 1.25f;
static constexpr double arrowHeadHeight = arrowHeadRadius * 3.f;
static constexpr float arrowHeadRadius = axisThickness * 1.25F;
static constexpr float arrowHeadHeight = arrowHeadRadius * 3.F;
static constexpr double labelOffset = 0.4f;
static constexpr double labelOffset = 0.4;
static constexpr int labelFontSize = 9;
static constexpr double scaleFactorDefault = 40.f;
static constexpr float scaleFactorDefault = 40.F;
SO_KIT_HEADER(SoFCPlacementIndicatorKit);

4
src/Gui/SoDatumLabel.cpp
View File

@@ -552,7 +552,7 @@ private:
float startangle = atan2f(vc1[1], vc1[0]);
float endangle = atan2f(vc2[1], vc2[0]);
if (endangle < startangle) {
endangle += 2. * std::numbers::pi;
endangle += 2.F * std::numbers::pi_v<float>;
}
SbVec3f textCenter;
@@ -697,7 +697,7 @@ SbVec3f SoDatumLabel::getLabelTextCenterArcLength(const SbVec3f& ctr, const SbVe
float endangle = atan2f(vc2[1], vc2[0]);
if (endangle < startangle) {
endangle += 2. * std::numbers::pi;
endangle += 2.F * std::numbers::pi_v<float>;
}
// Text location

2
src/Gui/View3DInventorViewer.cpp
View File

@@ -3606,7 +3606,7 @@ void View3DInventorViewer::alignToSelection()
angle *= -1;
}
using std::numbers::pi;
constexpr auto pi = std::numbers::pi_v<float>;
// Make angle positive
if (angle < 0) {