kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Part/Toponaming: Transfer WireJoiner

Browse Source 
* Added test for WireJoiner::Build()
 * Fixed typo in test for WireJoiner::getResultWires()

Signed-off-by: CalligaroV <vincenzo.calligaro@gmail.com>
This commit is contained in:
CalligaroV
2024-03-13 20:39:26 +01:00
parent 8c757a9fd1
commit ca0f58c389
1 changed files with 39 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
tests/src/Mod/Part/App/WireJoiner.cpp
View File

@@ -750,7 +750,7 @@ TEST_F(WireJoinerTest, getResultWires)
// wjOp.Build() is called by wjOp.getResultWires()
wjOp.getResultWires(wireOp, "getResultWires");
// Arrange
// Assert
// All the edges added with wjNoResultWires.addShape() can't create a closed wire, therefor
// wireNoResultWires shouldn't have any edges
@@ -771,4 +771,42 @@ TEST_F(WireJoinerTest, getResultWires)
EXPECT_NE(wireOp.getElementMap()[0].name.find("getResultWires"), -1);
}
#if OCC_VERSION_HEX >= 0x070600
// WireJoiner::Build() has already been tested indirectly in the other tests.
// Here we check only the difference with OCCT versions >= 7.6.0 that add the parameter theRange
TEST_F(WireJoinerTest, Build)
{
// Arrange
// Create various edges that will be used for the WireJoiner objects tests
auto edge1 {BRepBuilderAPI_MakeEdge(gp_Pnt(-0.1, 0.0, 0.0), gp_Pnt(1.1, 0.0, 0.0)).Edge()};
auto edge2 {BRepBuilderAPI_MakeEdge(gp_Pnt(1.0, -0.1, 0.0), gp_Pnt(1.0, 1.1, 0.0)).Edge()};
auto edge3 {BRepBuilderAPI_MakeEdge(gp_Pnt(1.1, 1.1, 0.0), gp_Pnt(-0.1, -0.1, 0.0)).Edge()};
// A vector of edges used as argument for wjtheRange.addShape()
std::vector<TopoDS_Shape> edgestheRange {edge1, edge2, edge3};
// A WireJoiner object that will create no closed wires
auto wjtheRange {WireJoiner()};
// A Message_ProgressRange object that will be used as argument for wjtheRange.Build()
auto mpr {Message_ProgressRange()};
// Act
wjtheRange.addShape(edgestheRange);
wjtheRange.Build(mpr);
// Assert
// theRange isn't used in WireJoiner::Build() and therefor not attached to any indicator.
// For more reference see
// https://dev.opencascade.org/doc/occt-7.6.0/refman/html/class_message___progress_range.html
// and
// https://dev.opencascade.org/doc/occt-7.6.0/refman/html/class_message___progress_indicator.html
EXPECT_FALSE(mpr.IsActive());
}
#endif
// NOLINTEND(readability-magic-numbers,cppcoreguidelines-avoid-magic-numbers)