[TD]review comments and rebase for PR7197

This commit is contained in:
Wanderer Fan
2022-07-20 11:53:21 -04:00
committed by WandererFan
parent 5fcea95ed1
commit cc2648b399
4 changed files with 7 additions and 3 deletions

View File

@@ -76,10 +76,11 @@ void DrawRichAnno::onChanged(const App::Property* prop)
}
//NOTE: DocumentObject::mustExecute returns 1/0 and not true/false
short DrawRichAnno::mustExecute() const
{
if (!isRestoring() && AnnoText.isTouched()) {
return true;
return 1;
}
return DrawView::mustExecute();

View File

@@ -75,6 +75,7 @@ DrawViewArch::~DrawViewArch()
{
}
//NOTE: DocumentObject::mustExecute returns 1/0 and not true/false
short DrawViewArch::mustExecute() const
{
if (!isRestoring()) {
@@ -89,7 +90,7 @@ short DrawViewArch::mustExecute() const
CutLineWidth.isTouched() ||
JoinArch.isTouched()
) {
return true;
return 1;
}
}
return DrawViewSymbol::mustExecute();

View File

@@ -197,6 +197,7 @@ void DrawViewBalloon::handleChangedPropertyType(Base::XMLReader &reader, const c
}
}
//NOTE: DocumentObject::mustExecute returns 1/0 and not true/false
short DrawViewBalloon::mustExecute() const
{
if (!isRestoring() && Text.isTouched()) {

View File

@@ -122,13 +122,14 @@ App::DocumentObjectExecReturn *DrawViewClip::execute(void)
return DrawView::execute();
}
//NOTE: DocumentObject::mustExecute returns 1/0 and not true/false
short DrawViewClip::mustExecute() const
{
if (!isRestoring()) {
if (Height.isTouched() ||
Width.isTouched() ||
Views.isTouched()) {
return true;
return 1;
}
}
return TechDraw::DrawView::mustExecute();