kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[TD]more stringent test for bsplines as circles

Browse Source
This commit is contained in:
wandererfan
2025-07-15 22:42:34 -04:00
committed by Chris Hennes
parent aee7354dea
commit cc3fb04e2b
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Mod/TechDraw/App/Geometry.cpp
View File

@@ -1529,13 +1529,14 @@ bool GeometryUtils::getCircleParms(const TopoDS_Edge& occEdge, double& radius, B
pointsOnCurve.push_back(Base::convertTo<Base::Vector3d>(newpoint));
}
auto edgeLong = edgeLength(occEdge);
constexpr double LimitFactor{0.001}; // 0.1% not sure about this value
double tolerance = edgeLong * LimitFactor;
double tolerance = EWTOLERANCE; // not as demanding as Precision::Confusion() but more
// demanding than using the edge length
isArc = true;
if (firstPoint.IsEqual(lastPoint, tolerance)) {
isArc = false;
isArc = false;
if (!firstPoint.IsEqual(lastPoint, tolerance)) {
// we were dropping information by not including lastPoint
pointsOnCurve.push_back(lastPoint);
isArc = true;
}
int passCount{0};
@@ -1576,6 +1577,7 @@ bool GeometryUtils::getCircleParms(const TopoDS_Edge& occEdge, double& radius, B
return true;
}
catch (Standard_Failure&) {
// we think this is a circle, but occt disagrees
Base::Console().message("Geo::getCircleParms - failed to make a circle\n");
}