[Draft] Add better error message in get_svg for direction

An AttributeError is raised when `direction=Vector(0,0,0)` and obj is
an Arch::Space on line: a3fb3cc804/src/Mod/Draft/draftfunctions/svg.py (L799)

This patch checks if early on if the direction vector and raises a
ValueError with a description of what has gone wrong.

A caveat with this solution is that this new behaviour might break old
code which depends on that invalid directions can be used.
This commit is contained in:
Benjamin Nauck
2021-01-31 20:24:59 +01:00
parent 049fd712e3
commit ce7856d51f
2 changed files with 24 additions and 0 deletions

View File

@@ -468,6 +468,8 @@ def get_svg(obj,
plane.alignToPointAndAxis_SVG(App.Vector(0, 0, 0),
direction.negative().negative(),
0)
else:
raise ValueError("'direction' cannot be: Vector(0, 0, 0)")
elif isinstance(direction, WorkingPlane.plane):
plane = direction

View File

@@ -87,6 +87,28 @@ class DraftSVG(unittest.TestCase):
obj = Draft.export_svg(out_file)
self.assertTrue(obj, "'{}' failed".format(operation))
def test_get_svg_from_arch_space_with_zero_vector(self):
"""Try to get a svg string from an Arch Space with a zero-vector as direction."""
import Part
import Arch
import Draft
sb = Part.makeBox(1,1,1)
b = App.ActiveDocument.addObject('Part::Feature','Box')
b.Shape = sb
s = Arch.makeSpace(b)
App.ActiveDocument.recompute()
try:
Draft.get_svg(s, direction=App.Vector(0,0,0))
except AttributeError as err:
self.fail("Cryptic exception thrown: {}".format(err))
except ValueError as err:
App.Console.PrintLog("Exception thrown, OK: {}".format(err))
else:
self.fail("no exception thrown")
def tearDown(self):
"""Finish the test.