Merge pull request 'fix(assembly): classify datum plane references in Distance joints' (#315) from fix/distance-datum-plane-classification into main
Some checks failed
Build and Test / build (push) Has been cancelled
Some checks failed
Build and Test / build (push) Has been cancelled
Reviewed-on: #315
This commit was merged in pull request #315.
This commit is contained in:
@@ -177,23 +177,33 @@ DistanceType getDistanceType(App::DocumentObject* joint)
|
||||
}
|
||||
|
||||
// One side is a datum plane, the other has a real element type.
|
||||
// Ensure the datum (plane) side is Reference1 for consistent
|
||||
// convention (face/plane first), matching the existing swap logic.
|
||||
// For PointPlane/LinePlane, the solver's PointInPlaneConstraint
|
||||
// reads the plane normal from marker_j (Reference2). Unlike
|
||||
// real Face+Vertex joints (where both Placements carry the
|
||||
// face normal from findPlacement), datum planes only carry
|
||||
// their normal through computeMarkerTransform. So the datum
|
||||
// must end up on Reference2 for the normal to reach marker_j.
|
||||
//
|
||||
// For PlanePlane the convention matches the existing Face+Face
|
||||
// path (plane on Reference1).
|
||||
const auto& otherType = datum1 ? type2 : type1;
|
||||
if (!datum1) {
|
||||
swapJCS(joint);
|
||||
}
|
||||
|
||||
if (otherType == "Vertex") {
|
||||
return DistanceType::PointPlane;
|
||||
}
|
||||
if (otherType == "Edge") {
|
||||
if (otherType == "Vertex" || otherType == "Edge") {
|
||||
// Datum must be on Reference2 (j side).
|
||||
if (datum1) {
|
||||
swapJCS(joint); // move datum from Ref1 → Ref2
|
||||
}
|
||||
if (otherType == "Vertex") {
|
||||
return DistanceType::PointPlane;
|
||||
}
|
||||
return DistanceType::LinePlane;
|
||||
}
|
||||
if (otherType == "Face") {
|
||||
return DistanceType::PlanePlane;
|
||||
|
||||
// Face + datum or unknown + datum → PlanePlane
|
||||
// Datum on Reference1 for consistency with Face+Face path.
|
||||
if (!datum1) {
|
||||
swapJCS(joint); // move datum from Ref2 → Ref1
|
||||
}
|
||||
// Unknown element + datum plane → best-effort planar
|
||||
return DistanceType::PlanePlane;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user