kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[TD]remove unused override methods

Browse Source
This commit is contained in:
wandererfan
2023-03-10 14:03:08 -05:00
committed by WandererFan
parent 3c31007e58
commit d0c5b7c045
10 changed files with 19 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp
View File

@@ -83,7 +83,12 @@ void ViewProviderDrawingView::attach(App::DocumentObject *pcFeat)
auto bndProgressMessage = boost::bind(&ViewProviderDrawingView::onProgressMessage, this, bp::_1, bp::_2, bp::_3);
auto feature = getViewObject();
if (feature) {
m_myName = feature->getNameInDocument();
const char* temp = feature->getNameInDocument();
if (temp) {
// it could happen that feature is not completely in the document yet and getNameInDocument returns
// nullptr, so we only update m_myName if we got a valid string.
m_myName = temp;
}
connectGuiRepaint = feature->signalGuiPaint.connect(bnd);
connectProgressMessage = feature->signalProgressMessage.connect(bndProgressMessage);
//TODO: would be good to start the QGIV creation process here, but no guarantee we actually have

2
src/Mod/TechDraw/Gui/ViewProviderLeader.h
View File

@@ -54,9 +54,7 @@ public:
App::PropertyEnumeration LineStyle;
App::PropertyColor Color;
/* virtual void setDisplayMode(const char* ModeName);*/
bool useNewSelectionModel() const override {return false;}
/* virtual std::vector<std::string> getDisplayModes(void) const;*/
void updateData(const App::Property*) override;
void onChanged(const App::Property* p) override;
bool setEdit(int ModNum) override;

22
src/Mod/TechDraw/Gui/ViewProviderPage.cpp
View File

@@ -91,6 +91,8 @@ ViewProviderPage::ViewProviderPage()
(App::PropertyType::Prop_None), "Grid line spacing in mm");
ShowFrames.setStatus(App::Property::Hidden, true);
// Do not show in property editor why? wf WF: because DisplayMode applies only to coin and we
// don't use coin.
DisplayMode.setStatus(App::Property::Hidden, true);
m_graphicsScene = new QGSPage(this);
@@ -115,24 +117,16 @@ void ViewProviderPage::attach(App::DocumentObject* pcFeat)
TechDraw::DrawPage* feature = dynamic_cast<TechDraw::DrawPage*>(pcFeat);
if (feature) {
connectGuiRepaint = feature->signalGuiPaint.connect(bnd);
m_pageName = feature->getNameInDocument();
const char* temp = feature->getNameInDocument();
if (temp) {
// it could happen that feature is not completely in the document yet and getNameInDocument returns
// nullptr, so we only update m_myName if we got a valid string.
m_pageName = temp;
}
m_graphicsScene->setObjectName(QString::fromLocal8Bit(m_pageName.c_str()));
}
}
void ViewProviderPage::setDisplayMode(const char* ModeName)
{
ViewProviderDocumentObject::setDisplayMode(ModeName);
}
std::vector<std::string> ViewProviderPage::getDisplayModes() const
{
// get the modes of the father
std::vector<std::string> StrList = ViewProviderDocumentObject::getDisplayModes();
StrList.emplace_back("Drawing");
return StrList;
}
void ViewProviderPage::onChanged(const App::Property* prop)
{
if (prop == &(ShowGrid)) {

3
src/Mod/TechDraw/Gui/ViewProviderPage.h
View File

@@ -66,7 +66,6 @@ public:
App::PropertyDistance GridSpacing;
void attach(App::DocumentObject*) override;
void setDisplayMode(const char* ModeName) override;
bool canDragObjects() const override;
bool canDragObject(App::DocumentObject* docObj) const override;
@@ -79,8 +78,6 @@ public:
const std::vector<std::string>& elements) const override;
bool useNewSelectionModel() const override { return false; }
/// returns a list of all possible modes
std::vector<std::string> getDisplayModes() const override;
/// Hides the view provider
void hide() override;
/// Shows the view provider

8
src/Mod/TechDraw/Gui/ViewProviderProjGroup.cpp
View File

@@ -59,14 +59,6 @@ ViewProviderProjGroup::~ViewProviderProjGroup()
{
}
std::vector<std::string> ViewProviderProjGroup::getDisplayModes() const
{
// get the modes of the father
std::vector<std::string> StrList = ViewProviderDrawingView::getDisplayModes();
StrList.emplace_back("Drawing");
return StrList;
}
void ViewProviderProjGroup::setupContextMenu(QMenu* menu, QObject* receiver, const char* member)
{
Q_UNUSED(menu);

2
src/Mod/TechDraw/Gui/ViewProviderProjGroup.h
View File

@@ -42,8 +42,6 @@ public:
~ViewProviderProjGroup() override; /// destructor
bool useNewSelectionModel() const override {return false;}
/// returns a list of all possible modes
std::vector<std::string> getDisplayModes() const override;
/// Claim all the views for the page
std::vector<App::DocumentObject*> claimChildren() const override;

8
src/Mod/TechDraw/Gui/ViewProviderProjGroupItem.cpp
View File

@@ -51,14 +51,6 @@ ViewProviderProjGroupItem::~ViewProviderProjGroupItem()
{
}
std::vector<std::string> ViewProviderProjGroupItem::getDisplayModes() const
{
// get the modes of the father
std::vector<std::string> StrList = ViewProviderViewPart::getDisplayModes();
StrList.emplace_back("Drawing");
return StrList;
}
void ViewProviderProjGroupItem::updateData(const App::Property* prop)
{
Gui::ViewProviderDocumentObject::updateData(prop);

2
src/Mod/TechDraw/Gui/ViewProviderProjGroupItem.h
View File

@@ -43,8 +43,6 @@ public:
~ViewProviderProjGroupItem() override;
bool useNewSelectionModel() const override {return false;}
/// returns a list of all possible modes
std::vector<std::string> getDisplayModes() const override;
/// Is called by the tree if the user double click on the object
bool doubleClicked() override;

2
src/Mod/TechDraw/Gui/ViewProviderTemplate.cpp
View File

@@ -62,6 +62,8 @@ ViewProviderTemplate::ViewProviderTemplate() : m_myName(std::string())
sPixmap = "TechDraw_TreePageTemplate";
// Do not show in property editor why? wf WF: because DisplayMode applies only to coin and we
// don't use coin.
DisplayMode.setStatus(App::Property::Hidden, true);
}

6
src/Mod/TechDraw/Gui/ViewProviderViewClip.cpp
View File

@@ -41,9 +41,9 @@ ViewProviderViewClip::ViewProviderViewClip()
{
sPixmap = "actions/TechDraw_ClipGroup";
// Do not show in property editor
//DisplayMode.StatusBits.set(3, true);
DisplayMode.setStatus(App::Property::ReadOnly, true);
// Do not show in property editor why? wf WF: because DisplayMode applies only to coin and we
// don't use coin.
DisplayMode.setStatus(App::Property::Hidden, true);
}
ViewProviderViewClip::~ViewProviderViewClip()