kindred/create
1
1
Fork 0
Code Issues 31 Pull Requests Actions 5 Packages Projects 9 Releases 2 Wiki Activity

[Part] remove code for < GCC 4.8

Browse Source 
we don't support such old GCC versions anymore so I think this can be removed
This commit is contained in:
Uwe
2022-07-23 15:54:32 +02:00
parent 76ec5de64b
commit d1e72dcafa
1 changed files with 2 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/Mod/Part/App/GeometryDefaultExtension.cpp
View File

@@ -72,24 +72,11 @@ std::unique_ptr<Part::GeometryExtension> GeometryDefaultExtension<T>::copy() con
copyAttributes(cpy.get());
#if (defined(__GNUC__) && __GNUC__ < 7 ) || defined(_MSC_VER)
return std::move(cpy); // GCC 4.8 and MSC do not support automatic move constructor call if the compiler fails to elide
#if defined(_MSC_VER)
return std::move(cpy); // MSC does not support automatic move constructor call if the compiler fails to elide
#else
return cpy; // all the others do automatic move constructor if RVO optimization not possible.
#endif
// Advise from Scott Meyers Effective Modern c++:
//
// Don't std::move(cpy); RVO optimization Item 25, if the compiler fails to elide, would have to move it anyway
// move constructor is executed if available (it is). Unique_ptr does not have copy constructor.
//
// That would work perfectly with GCC 7.3.0. However, GCC 4.8.4 misserably fails:
//
// /home/travis/build/FreeCAD/FreeCAD/src/Mod/Part/App/GeometryDefaultExtension.cpp: In instantiation of
// 'std::unique_ptr<Part::GeometryExtension> Part::GeometryDefaultExtension<T>::copy() const [with T = long int]':
// /home/travis/build/FreeCAD/FreeCAD/src/Mod/Part/App/GeometryDefaultExtension.cpp:164:16: required from here
// /home/travis/build/FreeCAD/FreeCAD/src/Mod/Part/App/GeometryDefaultExtension.cpp:84:12: error: cannot bind //
// 'std::unique_ptr<Part::GeometryDefaultExtension<long int>, std::default_delete<Part::GeometryDefaultExtension<long int> > >' lvalue
// to 'std::unique_ptr<Part::GeometryDefaultExtension<long int>, std::default_delete<Part::GeometryDefaultExtension<long int> > >&&'
}
template <typename T>