kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PartDesign: FeatureLinearPattern fix Axis-Y not working (#23637)

Browse Source 
* PartDesign: FeatureLinearPattern prevent error message

* To squash
This commit is contained in:
PaddleStroke
2025-09-08 18:26:30 +02:00
committed by GitHub
parent ee8818431c
commit d22b44cc70
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Gui/ComboLinks.cpp
View File

@@ -85,10 +85,6 @@ namespace Gui {
{
App::PropertyLinkSub lnk;
std::vector<std::string> sub = { linkSubname };
// Handle empty subname correctly
if (linkSubname.empty()) {
sub.clear();
}
lnk.setValue(linkObj, sub);
return addLink(lnk, itemText, userData);
}

16
src/Mod/PartDesign/App/FeatureLinearPattern.cpp
View File

@@ -248,17 +248,20 @@ const std::list<gp_Trsf> LinearPattern::getTransformations(const std::vector<App
gp_Vec LinearPattern::calculateOffsetVector(LinearPatternDirection dir) const
{
const auto& occurrencesProp =
(dir == LinearPatternDirection::First) ? Occurrences : Occurrences2;
bool firstDir = dir == LinearPatternDirection::First;
const auto& occurrencesProp = firstDir ? Occurrences : Occurrences2;
int occurrences = occurrencesProp.getValue();
if (occurrences <= 1) {
return gp_Vec(); // Return zero vector if no transformation is needed
}
const auto& dirProp = (dir == LinearPatternDirection::First) ? Direction : Direction2;
const auto& reversedProp = (dir == LinearPatternDirection::First) ? Reversed : Reversed2;
const auto& modeProp = (dir == LinearPatternDirection::First) ? Mode : Mode2;
const auto& lengthProp = (dir == LinearPatternDirection::First) ? Length : Length2;
const auto& dirProp = firstDir ? Direction : Direction2;
if (!dirProp.getValue()) {
return gp_Vec();
}
const auto& reversedProp = firstDir ? Reversed : Reversed2;
const auto& modeProp = firstDir ? Mode : Mode2;
const auto& lengthProp = firstDir ? Length : Length2;
double distance = lengthProp.getValue();
if (distance < Precision::Confusion()) {
@@ -552,3 +555,4 @@ void LinearPattern::syncLengthAndOffset(LinearPatternDirection dir)
}