kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Sketcher: Change behaviour of toggle of mixed group of edges and vertices

Browse Source 
=========================================================================

Forum:
https://forum.freecad.org/viewtopic.php?p=677304#p677304

A common operation is to toggle a group of geometry to/from construction. This happens often
in connection with carbon copy operations.

When this happens, geometry is often selected using box selection.

If there are geometry points (which are generally construction), and selection box is used, this
results in construction points being toggled to normal defining mode. This situation is undesirable
in 99% of the cases. It requires to reselect only the points and toggle them back.

When construction points need be made defining geometry (for example to use them as attachments), the
general workflow is to select only those points and toggle them.

In order to improve the efficiency, it has been decided to provide a special behaviour for construction
toggling:

1. Vertices will only be toggled to/from construction IF ONLY vertices are selected.
2. If there is a mixture of edges and vertices, vertices will be ignored during the toggling operation.
This commit is contained in:
Abdullah Tahiri
2023-04-22 21:19:28 +02:00
committed by abdullahtahiriyo
parent 562c967082
commit d656d4e959
1 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/Mod/Sketcher/Gui/CommandAlterGeometry.cpp
View File

@@ -155,14 +155,34 @@ void CmdSketcherToggleConstruction::activated(int iMsg)
openCommand(QT_TRANSLATE_NOOP("Command", "Toggle draft from/to draft"));
// go through the selected subelements
bool verticesonly = true;
for(const auto & subname : SubNames) {
if (subname.size() > 4 && subname.substr(0,4) == "Edge") {
verticesonly = false;
}
}
for (std::vector<std::string>::const_iterator it=SubNames.begin();it!=SubNames.end();++it){
// It was decided to provide a special behaviour:
// Vertices will only be toggled to/from construction IF ONLY
// vertices are within the group.
// If there are a mixture of edges and vertices, vertices will be ignored.
//
// Why?
// Because it is quite common to box select geometry for toggling (specially in
// connection with carbon copy operations). In 99% of the cases the user does not
// want to toggle individual points during such operations. For the remaining 1%,
// in 90% of the cases the uses will select just the points only naturally.
// only handle edges
if (it->size() > 4 && it->substr(0,4) == "Edge") {
int GeoId = std::atoi(it->substr(4,4000).c_str()) - 1;
// issue the actual commands to toggle
Gui::cmdAppObjectArgs(selection[0].getObject(), "toggleConstruction(%d) ", GeoId);
}
if (it->size() > 6 && it->substr(0,6) == "Vertex") {
else if (verticesonly && it->size() > 6 && it->substr(0,6) == "Vertex") {
int vertexId = std::atoi(it->substr(6,4000).c_str()) - 1;
int geoId;