kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Draft: Fix upgrade function: delete argument was ignored in case of draftify

Browse Source 
Forum topic:
https://forum.freecad.org/viewtopic.php?t=91357
This commit is contained in:
Roy-043
2024-10-13 16:30:34 +02:00
committed by Chris Hennes
parent 14068183b7
commit d71fcf7593
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Mod/Draft/draftfunctions/upgrade.py
View File

@@ -482,9 +482,10 @@ def upgrade(objects, delete=False, force=None):
# only one object: if not parametric, we "draftify" it
elif (len(objects) == 1
and not objects[0].isDerivedFrom("Part::Part2DObjectPython")):
result = draftify.draftify(objects[0])
result = draftify.draftify(objects[0], delete=False)
if result:
add_list.append(result)
delete_list.append(objects[0])
_msg(translate("draft","Found 1 non-parametric objects: draftifying it"))
# in the following cases there are no faces
@@ -516,23 +517,16 @@ def upgrade(objects, delete=False, force=None):
_msg(translate("draft","trying: closing it"))
if result:
_msg(translate("draft","Found 1 open wire: closing it"))
# we have only one object that contains one edge
# TODO: improve draftify function
# only one object: if not parametric, we "draftify" it
# elif (len(objects) == 1
# and not objects[0].isDerivedFrom("Part::Part2DObjectPython")):
# result = draftify.draftify(objects[0])
# if result:
# _msg(translate("draft","Found 1 non-parametric objects: draftifying it"))
elif (len(objects) == 1 and len(edges) == 1
and not objects[0].isDerivedFrom("Part::Part2DObjectPython")):
e = objects[0].Shape.Edges[0]
edge_type = DraftGeomUtils.geomType(e)
# currently only support Line and Circle
if edge_type in ("Line", "Circle"):
result = draftify.draftify(objects[0])
result = draftify.draftify(objects[0], delete=False)
if result:
add_list.append(result)
delete_list.append(objects[0])
_msg(translate("draft","Found 1 object: draftifying it"))
# only points, no edges
elif not edges and len(objects) > 1: