kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

NotificationArea: Correct painting position

Browse Source 
===========================================

QT has a open bug regarding filling the contents of a QMenu in aboutShow:
https://bugreports.qt.io/browse/QTBUG-54421

This commit presents a work-around this bug.

The two step procedure of this commit, forces a recalculation of the size
from the slot and then manually moves the widget to the right position.
This commit is contained in:
Abdullah Tahiri
2023-03-26 19:14:39 +02:00
committed by abdullahtahiriyo
parent d246f36932
commit da76caa13e
1 changed files with 40 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/Gui/NotificationArea.cpp
View File

@@ -510,6 +510,11 @@ public:
pushedItems.push_front(item);
}
QSize size()
{
return tableWidget->size();
}
protected:
/// creates the Notifications Widget
QWidget* createWidget(QWidget* parent) override
@@ -759,11 +764,42 @@ NotificationArea::NotificationArea(QWidget* parent)
}
static_cast<NotificationsAction*>(pImp->notificationaction)->synchroniseWidget();
// the position of the action has already been calculated (for a non-synchronised widget),
// the size could be recalculated here, but not the position according to the previous size.
// This resize event forces this recalculation.
QResizeEvent re(pImp->menu->size(), pImp->menu->size());
// There is a Qt bug in not respecting a QMenu size when size changes in aboutToShow.
//
// https://bugreports.qt.io/browse/QTBUG-54421
// https://forum.qt.io/topic/68765/how-to-update-geometry-on-qaction-visibility-change-in-qmenu-abouttoshow/3
//
// None of this works
// pImp->menu->updateGeometry();
// pImp->menu->adjustSize();
// pImp->menu->ensurePolished();
// this->updateGeometry();
// this->adjustSize();
// this->ensurePolished();
// This does correct the size
QSize size = static_cast<NotificationsAction*>(pImp->notificationaction)->size();
QResizeEvent re(size, size);
qApp->sendEvent(pImp->menu, &re);
// This corrects the position of the menu
QTimer::singleShot(0, [&] {
QWidget* statusbar = static_cast<QWidget*>(this->parent());
QPoint statusbar_top_right = statusbar->mapToGlobal(statusbar->rect().topRight());
QSize menusize = pImp->menu->size();
QWidget* w = this;
QPoint button_pos = w->mapToGlobal(w->rect().topLeft());
QPoint widget_pos;
if ((statusbar_top_right.x() - menusize.width()) > button_pos.x()) {
widget_pos = QPoint(button_pos.x(), statusbar_top_right.y() - menusize.height());
}
else {
widget_pos = QPoint(statusbar_top_right.x() - menusize.width(),
statusbar_top_right.y() - menusize.height());
}
pImp->menu->move(widget_pos);
});
});