kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Sketcher: avoid attaching to/detaching from the same parameter group twice

Browse Source
This commit is contained in:
wmayer
2022-01-05 14:05:05 +01:00
parent 4e2c1158c6
commit ddbf8e0e2d
2 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Mod/PartDesign/App/FeatureHole.cpp
View File

@@ -2200,7 +2200,7 @@ void from_json(const nlohmann::json &j, Hole::CutDimensionSet &t)
else if (thread_type_string == "metricfine")
t.thread_type = Hole::CutDimensionSet::MetricFine;
else
throw Base::IndexError(std::string("Thread type ‘") + thread_type_string + "’ unsupported");
throw Base::IndexError(std::string(u8"Thread type ‘") + thread_type_string + u8"’ unsupported");
std::string cut_type_string = j["cut_type"].get<std::string>();
if (cut_type_string == "counterbore") {

6
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp
View File

@@ -185,9 +185,6 @@ void ViewProviderSketch::ParameterObserver::subscribeToParameters()
ParameterGrp::handle hGrp = App::GetApplication().GetParameterGroupByPath("User parameter:BaseApp/Preferences/Mod/Sketcher/General");
hGrp->Attach(this);
ParameterGrp::handle hGrpskg = App::GetApplication().GetParameterGroupByPath("User parameter:BaseApp/Preferences/Mod/Sketcher/General");
hGrpskg->Attach(this);
ParameterGrp::handle hGrp2 = App::GetApplication().GetParameterGroupByPath("User parameter:BaseApp/Preferences/Mod/Sketcher");
hGrp2->Attach(this);
}
@@ -197,9 +194,6 @@ void ViewProviderSketch::ParameterObserver::unsubscribeToParameters()
ParameterGrp::handle hGrp = App::GetApplication().GetParameterGroupByPath("User parameter:BaseApp/Preferences/Mod/Sketcher/General");
hGrp->Detach(this);
ParameterGrp::handle hGrpskg = App::GetApplication().GetParameterGroupByPath("User parameter:BaseApp/Preferences/Mod/Sketcher/General");
hGrpskg->Detach(this);
ParameterGrp::handle hGrp2 = App::GetApplication().GetParameterGroupByPath("User parameter:BaseApp/Preferences/Mod/Sketcher");
hGrp2->Detach(this);
}