kindred/create
1
1
Fork 0
Code Issues 32 Pull Requests Actions 5 Packages Projects 9 Releases 2 Wiki Activity

Sketcher: Avoid transfering angle constraints

Browse Source 
=============================================

Angle constraints are internally coded using the diverging points of the segments (PointPos != none) in normal 2 segment angle constraints.

This creates a problem with the mechanism to transfer enpoints on angle deletion.

fixes #3589
This commit is contained in:
Abdullah Tahiri
2018-10-08 14:24:22 +02:00
committed by wmayer
parent dc023afc84
commit e66849378b
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/Mod/Sketcher/App/SketchObject.cpp
View File

@@ -1148,8 +1148,17 @@ int SketchObject::transferConstraints(int fromGeoId, PointPos fromPosId, int toG
constNew->First = toGeoId;
constNew->FirstPos = toPosId;
if(vals[i]->Type == Sketcher::Tangent || vals[i]->Type == Sketcher::Perpendicular)
if(vals[i]->Type == Sketcher::Tangent || vals[i]->Type == Sketcher::Perpendicular){
constNew->Type = Sketcher::Coincident;
}
// with respect to angle constraints, if it is a DeepSOIC style angle constraint (segment+segment+point), then no problem arises
// as the segments are PosId=none. In this case there is not call to this function.
//
// However, other angle constraints are problematic because they are created on segments, but internally operate on vertices, PosId=start
// such constraint may not be succesfully transfered on deletion of the segments.
else if(vals[i]->Type == Sketcher::Angle) {
continue;
}
newVals[i] = constNew;
changed.push_back(constNew);
@@ -1164,8 +1173,12 @@ int SketchObject::transferConstraints(int fromGeoId, PointPos fromPosId, int toG
// Nothing guarantees that a tangent can be freely transferred to another coincident point, as
// the transfer destination edge most likely won't be intended to be tangent. However, if it is
// an end to end point tangency, the user expects it to be substituted by a coincidence constraint.
if(vals[i]->Type == Sketcher::Tangent || vals[i]->Type == Sketcher::Perpendicular)
if(vals[i]->Type == Sketcher::Tangent || vals[i]->Type == Sketcher::Perpendicular) {
constNew->Type = Sketcher::Coincident;
}
else if(vals[i]->Type == Sketcher::Angle) {
continue;
}
newVals[i] = constNew;
changed.push_back(constNew);